From: Mark Rutland <mark.rutland@arm.com>
To: "Zhaoyang Huang (黄朝阳)" <Zhaoyang.Huang@spreadtrum.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Zhaoyang Huang <zhaoyang.huang@linaro.org>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hanjun.guo@linaro.org" <hanjun.guo@linaro.org>,
"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>
Subject: Re: [RFC PATCH] Add IPI entry for CPU UP
Date: Mon, 11 Jan 2016 11:03:06 +0000 [thread overview]
Message-ID: <20160111110305.GH6499@leverpostej> (raw)
In-Reply-To: <f6151f15eb374710b42faa2d12f352fe@SHMBX03.spreadtrum.com>
On Mon, Jan 11, 2016 at 10:55:08AM +0000, Zhaoyang Huang (黄朝阳) wrote:
>
> ________________________________________
> From: Catalin Marinas <catalin.marinas@arm.com>
> Sent: Monday, January 11, 2016 6:06 PM
> To: Lorenzo Pieralisi
> Cc: Zhaoyang Huang; Zhaoyang Huang (黄朝阳); will.deacon@arm.com; linux-kernel@vger.kernel.org; hanjun.guo@linaro.org; suzuki.poulose@arm.com; Mark Rutland
> Subject: Re: [RFC PATCH] Add IPI entry for CPU UP
>
> On Mon, Jan 11, 2016 at 09:59:25AM +0000, Lorenzo Pieralisi wrote:
> > On Mon, Jan 11, 2016 at 03:10:40PM +0800, Zhaoyang Huang wrote:
> > > In some ARM SOCs, IPI interrupt is used for hotplug in one cpu, that is,
> > > sending a IPI to the core in WFI and powerdown status. So Add a IPI
> > > entry for handle this kind of cpu up interrupt
> >
> > On arm64 SOCs, with a mainline kernel, you can only hotplug CPUs out
> > and back in by using the PSCI firmware interface, which does not
> > require an IPI to boot a CPU, therefore this patch is useless.
>
> I fully agree.
>
> BTW, such patches should cc linux-arm-kernel@lists.infradead.org as well
> since they are ARM related.
>
> Hi both,
> In fact, this patch is related to the counterpart of the PSCI code in
> kernel world which you mentioned before. In SPRD's SOC, we have to
> implement a way of "wakeup" the core in powerdown state, which is to
> launch a IPI to the dest core.
This is not required with PSCI, which abstracts the wakeup and power
management behind the CPU_ON call.
The kernel should only have to issue a CPU_ON call, and the firmware
should do the right thing behind the scenes (e.g. enabling power to the
core, sending an IPI if necessary).
If the kernel needs to do anything other than issue a CPU_ON call, this
is not PSCI.
> The reason why we can not accessing power related register to light on
> the core is the state machine of the PMU will not be safe for this
> scenario.
I'm not sure I understand.
Which software agent (kernel? firmware?) cannot access this PMU
register, and why?
What is the problem with the PMU state machine?
Thanks,
Mark.
next prev parent reply other threads:[~2016-01-11 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 7:10 [RFC PATCH] Add IPI entry for CPU UP Zhaoyang Huang
2016-01-11 9:59 ` Lorenzo Pieralisi
2016-01-11 10:06 ` Catalin Marinas
2016-01-11 10:55 ` Zhaoyang Huang (黄朝阳)
2016-01-11 11:03 ` Mark Rutland [this message]
2016-01-11 11:21 ` Zhaoyang Huang
2016-01-11 11:37 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111110305.GH6499@leverpostej \
--to=mark.rutland@arm.com \
--cc=Zhaoyang.Huang@spreadtrum.com \
--cc=catalin.marinas@arm.com \
--cc=hanjun.guo@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
--cc=zhaoyang.huang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox