From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759641AbcAKLLL (ORCPT ); Mon, 11 Jan 2016 06:11:11 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:40308 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759107AbcAKLLF (ORCPT ); Mon, 11 Jan 2016 06:11:05 -0500 Date: Mon, 11 Jan 2016 03:11:01 -0800 From: Guenter Roeck To: Sudip Mukherjee Cc: Greg Kroah-Hartman , Nicolas Ferre , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Gortmaker Subject: Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure Message-ID: <20160111111101.GA18945@roeck-us.net> References: <1452363335-2535-1-git-send-email-linux@roeck-us.net> <20160109182908.GB29967@kroah.com> <20160111083536.GB8070@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160111083536.GB8070@sudip-pc> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote: > On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote: > > On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote: > > > If serial/atmel_serial.c is compiled with devicetree enabled, the > > > following build error is observed. > > > > > > drivers/tty/serial/atmel_serial.c:192:1: warning: > > > data definition has no type or storage class > > > drivers/tty/serial/atmel_serial.c:192:1: error: > > > type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' > > > drivers/tty/serial/atmel_serial.c:192:1: warning: > > > parameter names (without types) in function declaration > > > > > > MODULE_DEVICE_TABLE is used to specify devicetree compatibilities. > > > > > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular") > > > Cc: Paul Gortmaker > > > Signed-off-by: Guenter Roeck > > > --- > > > drivers/tty/serial/atmel_serial.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > This hit my tree last night already with commit > > 041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the > > next linux-next release. > > Hi Guenter, > Just a thought. It has happended many times that we both have sent > patches to fix the same build fail. Maybe your patch got applied and > mine came late or maybe mine was applied and you came late. But I think > if we have a separate mailing list where people interested to fix and > monitor build failures will be members and we Cc that list whenever we > send patch for build fail and then in that case we will know that > someone else has already sent a patch for this failure and we can invest > the time in some other problem. > Hi Sudip, I agree, it would make sense to have a build(/runtime?)-fixes-only mailing list. Question though is how to limit noise on such a list and, of course, where and how to set it up. Any thoughts ? Guenter