From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759427AbcAKMjt (ORCPT ); Mon, 11 Jan 2016 07:39:49 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35854 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759384AbcAKMjs (ORCPT ); Mon, 11 Jan 2016 07:39:48 -0500 Date: Mon, 11 Jan 2016 13:39:44 +0100 From: Ingo Molnar To: Borislav Petkov Cc: Peter Zijlstra , X86 ML , LKML , Arnaldo Carvalho de Melo , Jiri Olsa , Thomas Gleixner Subject: Re: [RFC PATCH 0/5] perf: Sanitize perf directory structure, p1 Message-ID: <20160111123944.GA13637@gmail.com> References: <1450814151-21945-1-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450814151-21945-1-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > From: Borislav Petkov > > Hi guys, > > so what better time to do that fun than during the holidays when no one > else is producing patches. :-) > > Anyway, here's a part one conversion of the AMD perf events facilities. > Directory structure looks like this: > > arch/x86/events/ > |-- amd > | |-- core.c > | |-- ibs.c > | |-- iommu.c > | |-- iommu.h > | `-- uncore.c > |-- core.c > `-- Makefile > > and I've kept the churn at a mininum. Holler if something's not kosher. So it is only now that I noticed that we have both 'core.c' and 'uncore.c', which is slightly bit confusing: the core.c's we have around the kernel denote core subsystem functionality - not CPU core functionality. If we have uncore.c around, confusion might ensue. OTOH maybe it's not a big issue and we can just live with it. I'd hate to see main.c. Maybe rename 'uncore.c' to 'cpu_uncore.c'? OTOH that sounds a bit silly too. So maybe leave it as you named them. Thanks, Ingo