From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933451AbcAKOI6 (ORCPT ); Mon, 11 Jan 2016 09:08:58 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36553 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933125AbcAKOIz (ORCPT ); Mon, 11 Jan 2016 09:08:55 -0500 Date: Mon, 11 Jan 2016 19:38:50 +0530 From: Viresh Kumar To: Mans Rullgard Cc: Viresh Kumar , Andy Shevchenko , Dan Williams , Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dmaengine: dw: fix cyclic transfer setup Message-ID: <20160111140850.GA1084@ubuntu> References: <1452517469-26922-1-git-send-email-mans@mansr.com> <1452517469-26922-2-git-send-email-mans@mansr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452517469-26922-2-git-send-email-mans@mansr.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-01-16, 13:04, Mans Rullgard wrote: > Commit 61e183f83069 ("dmaengine/dw_dmac: Reconfigure interrupt and > chan_cfg register on resume") moved some channel initialisation to > a new function which must be called before starting a transfer. > > This updates dw_dma_cyclic_start() to use dwc_dostart() like the other > modes, thus ensuring dwc_initialize() gets called and removing some code > duplication. > > Fixes: 61e183f83069 ("dmaengine/dw_dmac: Reconfigure interrupt and chan_cfg register on resume") > Signed-off-by: Mans Rullgard > --- > Changes: > - replace duplicated code by dwc_dostart() call > --- > drivers/dma/dw/core.c | 23 +---------------------- > 1 file changed, 1 insertion(+), 22 deletions(-) Reviewed-by: Viresh Kumar -- viresh