From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933509AbcAKOK4 (ORCPT ); Mon, 11 Jan 2016 09:10:56 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34752 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933359AbcAKOKw (ORCPT ); Mon, 11 Jan 2016 09:10:52 -0500 Date: Mon, 11 Jan 2016 19:40:48 +0530 From: Viresh Kumar To: Mans Rullgard Cc: Viresh Kumar , Andy Shevchenko , Dan Williams , Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Message-ID: <20160111141048.GB1084@ubuntu> References: <1452517469-26922-1-git-send-email-mans@mansr.com> <1452517469-26922-3-git-send-email-mans@mansr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452517469-26922-3-git-send-email-mans@mansr.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-01-16, 13:04, Mans Rullgard wrote: > Cyclic transfer callbacks rely on block completion interrupts which were > disabled in commit ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block > interrupts"). This re-enables block interrupts so the cyclic callbacks > can work. Other transfer types are not affected as they set the INT_EN > bit only on the last block. > > Fixes: ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block interrupts") > Signed-off-by: Mans Rullgard > --- > Changes: > - new patch > --- > drivers/dma/dw/core.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) Reviewed-by: Viresh Kumar BTW, Shouldn't you mark these for stable trees as well ? :) -- viresh