From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
jolsa@kernel.org, namhyung@kernel.or, lizefan@huawei.com,
pi3orama@163.com, linux-kernel@vger.kernel.org,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf tools: Add missing sources in perf's MANIFEST
Date: Mon, 11 Jan 2016 11:12:28 -0300 [thread overview]
Message-ID: <20160111141228.GB18367@kernel.org> (raw)
In-Reply-To: <569379E2.9080106@huawei.com>
Em Mon, Jan 11, 2016 at 05:46:10PM +0800, Wangnan (F) escreveu:
> On 2016/1/11 17:43, Jiri Olsa wrote:
> >On Fri, Jan 08, 2016 at 02:23:57PM +0000, Wang Nan wrote:
> >>These losted headers are found in arm64 cross building:
> >>failed to build perf using tarball generated using
> >>
> >> $ make perf-targz-src-pkg
> >>
> >>Signed-off-by: Wang Nan <wangnan0@huawei.com>
> >>Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> >>Cc: Jiri Olsa <jolsa@kernel.org>
> >>Cc: Namhyung Kim <namhyung@kernel.org>
> >>---
> >> tools/perf/MANIFEST | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >>diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
> >>index ce3932e..c0053af 100644
> >>--- a/tools/perf/MANIFEST
> >>+++ b/tools/perf/MANIFEST
> >>@@ -1,6 +1,7 @@
> >> tools/perf
> >> tools/arch/alpha/include/asm/barrier.h
> >> tools/arch/arm/include/asm/barrier.h
> >>+tools/arch/arm64/include/asm/barrier.h
> >> tools/arch/ia64/include/asm/barrier.h
> >> tools/arch/mips/include/asm/barrier.h
> >> tools/arch/powerpc/include/asm/barrier.h
> >>@@ -30,6 +31,7 @@ tools/lib/util/find_next_bit.c
> >> tools/include/asm/atomic.h
> >> tools/include/asm/barrier.h
> >> tools/include/asm/bug.h
> >>+tools/include/asm-generic/atomic-gcc.h
> >> tools/include/asm-generic/barrier.h
> >> tools/include/asm-generic/bitops/arch_hweight.h
> >> tools/include/asm-generic/bitops/atomic.h
> >tarpkg test just failed for me due to missing bitmap sources
> >I needed to add.. seems related to:
> > 915b0882c310 tools lib: Move bitmap.[ch] from tools/perf/ to tools/{lib,include}/
> I also saw this:
> http://lkml.kernel.org/g/56931E12.8030506@huawei.com
> tarpkg works for me when I posted this patchset at Friday, but
> fail after I return back today...
Right, my turn, we all make mistakes ;-\
Anyway, I'm looking at git commit hooks to try and get this checked
automatically for future renames or when new files gets added that are
not listed in the MANIFEST file...
Thank you guys for spotting this! :-)
- Arnaldo
next prev parent reply other threads:[~2016-01-11 14:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 14:23 [PATCH 0/6] perf tools: Improve 'make build-test' Wang Nan
2016-01-08 14:23 ` [PATCH 1/6] perf tools: Add -lutil in python lib list for broken python-config Wang Nan
2016-01-11 9:28 ` Jiri Olsa
2016-01-11 9:44 ` Wangnan (F)
2016-01-11 9:50 ` Wangnan (F)
2016-01-12 9:41 ` Jiri Olsa
2016-01-08 14:23 ` [PATCH 2/6] perf tools: Add missing headers in perf's MANIFEST Wang Nan
2016-01-09 16:37 ` [tip:perf/core] perf tools: Add missing headers in perf' s MANIFEST tip-bot for Wang Nan
2016-01-11 9:43 ` [PATCH] perf tools: Add missing sources in perf's MANIFEST Jiri Olsa
2016-01-11 9:46 ` Wangnan (F)
2016-01-11 14:12 ` Arnaldo Carvalho de Melo [this message]
2016-01-08 14:23 ` [PATCH 3/6] perf tools: Fix phony build target for build-test Wang Nan
2016-01-11 9:29 ` Jiri Olsa
2016-01-08 14:23 ` [PATCH 4/6] perf tools: Set parallel making options build-test Wang Nan
2016-01-11 9:38 ` Jiri Olsa
2016-01-08 14:24 ` [PATCH 5/6] perf tools: Pass O option to Makefile.perf in build-test Wang Nan
2016-01-08 14:24 ` [PATCH 6/6] perf tools: Test correct path of perf " Wang Nan
2016-01-08 14:32 ` [PATCH 0/6] perf tools: Improve 'make build-test' Arnaldo Carvalho de Melo
2016-01-11 2:55 ` Wangnan (F)
2016-01-11 8:46 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111141228.GB18367@kernel.org \
--to=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=namhyung@kernel.or \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox