From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Jiri Olsa <jolsa@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH 0/5] perf: Sanitize perf directory structure, p1
Date: Mon, 11 Jan 2016 15:34:39 +0100 [thread overview]
Message-ID: <20160111143439.GA4665@pd.tnic> (raw)
In-Reply-To: <20160111123944.GA13637@gmail.com>
On Mon, Jan 11, 2016 at 01:39:44PM +0100, Ingo Molnar wrote:
> So it is only now that I noticed that we have both 'core.c' and 'uncore.c', which
> is slightly bit confusing: the core.c's we have around the kernel denote core
> subsystem functionality - not CPU core functionality. If we have uncore.c around,
> confusion might ensue.
>
> OTOH maybe it's not a big issue and we can just live with it. I'd hate to see
> main.c. Maybe rename 'uncore.c' to 'cpu_uncore.c'? OTOH that sounds a bit silly
> too. So maybe leave it as you named them.
Well, not doung anything should be ok because the *uncore* things would
go to the <vendor>/ subdir:
I.e.,
arch/x86/kernel/cpu/perf_event_amd_uncore.c
arch/x86/kernel/cpu/perf_event_intel_uncore.c
arch/x86/kernel/cpu/perf_event_intel_uncore.h
arch/x86/kernel/cpu/perf_event_intel_uncore_nhmex.c
arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c
arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c
will become
arch/x86/events/amd/uncore.c
arch/x86/events/intel/uncore.c
arch/x86/events/intel/uncore.h
arch/x86/events/intel/uncore_nhmex.c
arch/x86/events/intel/uncore_snb.c
arch/x86/events/intel/uncore_snbep.c
and core.c will be in the upper dir arch/x86/events/
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-01-11 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 19:55 [RFC PATCH 0/5] perf: Sanitize perf directory structure, p1 Borislav Petkov
2015-12-22 19:55 ` [RFC PATCH 1/5] x86/events: Move perf_event.c Borislav Petkov
2015-12-22 19:55 ` [RFC PATCH 2/5] x86/events: Move perf_event_amd.c Borislav Petkov
2015-12-22 19:55 ` [RFC PATCH 3/5] x86/events: Move perf_event_amd_ibs.c Borislav Petkov
2015-12-22 19:55 ` [RFC PATCH 4/5] x86/events: Move perf_event_amd_iommu.* Borislav Petkov
2015-12-28 15:50 ` Joerg Roedel
2015-12-29 8:50 ` Boris Petkov
2015-12-22 19:55 ` [RFC PATCH 5/5] x86/events: Move perf_event_amd_uncore.c Borislav Petkov
2016-01-11 12:39 ` [RFC PATCH 0/5] perf: Sanitize perf directory structure, p1 Ingo Molnar
2016-01-11 14:34 ` Borislav Petkov [this message]
2016-01-11 15:14 ` Ingo Molnar
2016-01-11 16:32 ` Borislav Petkov
2016-01-12 11:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111143439.GA4665@pd.tnic \
--to=bp@alien8.de \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).