From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760624AbcAKPOR (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jan 2016 10:14:17 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:35853 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759310AbcAKPOP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jan 2016 10:14:15 -0500
Date: Mon, 11 Jan 2016 16:14:12 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Jiri Olsa <jolsa@redhat.com>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH 0/5] perf: Sanitize perf directory structure, p1
Message-ID: <20160111151411.GC23096@gmail.com>
References: <1450814151-21945-1-git-send-email-bp@alien8.de>
 <20160111123944.GA13637@gmail.com>
 <20160111143439.GA4665@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160111143439.GA4665@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Borislav Petkov <bp@alien8.de> wrote:

> On Mon, Jan 11, 2016 at 01:39:44PM +0100, Ingo Molnar wrote:
> > So it is only now that I noticed that we have both 'core.c' and 'uncore.c', which 
> > is slightly bit confusing: the core.c's we have around the kernel denote core 
> > subsystem functionality - not CPU core functionality. If we have uncore.c around, 
> > confusion might ensue.
> > 
> > OTOH maybe it's not a big issue and we can just live with it. I'd hate to see 
> > main.c. Maybe rename 'uncore.c' to 'cpu_uncore.c'? OTOH that sounds a bit silly 
> > too. So maybe leave it as you named them.
> 
> Well, not doung anything should be ok because the *uncore* things would
> go to the <vendor>/ subdir:
> 
> I.e.,
> 
> arch/x86/kernel/cpu/perf_event_amd_uncore.c
> arch/x86/kernel/cpu/perf_event_intel_uncore.c
> arch/x86/kernel/cpu/perf_event_intel_uncore.h
> arch/x86/kernel/cpu/perf_event_intel_uncore_nhmex.c
> arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c
> arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c
> 
> will become
> 
> arch/x86/events/amd/uncore.c
> arch/x86/events/intel/uncore.c
> arch/x86/events/intel/uncore.h
> arch/x86/events/intel/uncore_nhmex.c
> arch/x86/events/intel/uncore_snb.c
> arch/x86/events/intel/uncore_snbep.c
> 
> and core.c will be in the upper dir arch/x86/events/

Ok, works for me. Got confused by your ascii art:

arch/x86/events/
|-- amd
|   |-- core.c
|   |-- ibs.c
|   |-- iommu.c
|   |-- iommu.h
|   `-- uncore.c
|-- core.c
`-- Makefile

which lists events/amd/core.c.

Thanks,

	Ingo