From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934020AbcAKQsC (ORCPT ); Mon, 11 Jan 2016 11:48:02 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47888 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933393AbcAKQr6 (ORCPT ); Mon, 11 Jan 2016 11:47:58 -0500 Date: Mon, 11 Jan 2016 16:47:44 +0000 From: Mark Brown To: Arnd Bergmann Cc: Liam Girdwood , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin Message-ID: <20160111164744.GM6588@sirena.org.uk> References: <7607130.s0M7SSqlJV@wuerfel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="onwk0SivC/dtQkFp" Content-Disposition: inline In-Reply-To: <7607130.s0M7SSqlJV@wuerfel> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: max8973: add THERMAL_OF dependency X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --onwk0SivC/dtQkFp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 08, 2016 at 09:06:43PM +0100, Arnd Bergmann wrote: > I've run into the same problem a couple of times now, with every driver > that calls thermal_zone_of_sensor_register(). I think we need a better > solution in general, but this fixes the immediate build error for now. Yes, this doesn't feel very clever especially in this use case where we're mostly providing data into the thermal framework and not really relying on it for anything. > Maybe we should replace the "#ifdef CONFIG_THERMAL_OF" with "#if > IS_REACHABLE(CONFIG_THERMAL) && IS_ENABLED(CONFIG_THERMAL_OF)"? > The disadvantage of that is that the thermal management would be > silently disabled rather than cause a link error, and that may also > not be desired. Perhaps we should ensure that at least some glue code is bool rather than modular? That's got downsides too, it increases the amount of code that gets built into the kernel but perhaps that's an acceptable tradeoff here. --onwk0SivC/dtQkFp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWk9yvAAoJECTWi3JdVIfQbgsH/RAvyucImi+oTbbwIJ/kXNpz zr8fDlaHs92d79F4xrghoGXcWXkbhozRaNQBXOIC74163Crn25vla/3JBk0jjCDJ AnGSs+t6/6Q7YzNmPnzlvTe+ZGwZf2bF/n1Bm4svgt/2Qtuy9/6AQBK2AGtFcAK3 SU7gkL/27VRAfNkK52hOZ18ms2F8Ga8fLBr12kuIOVUnQbtFOd5gYEiIc6buv1ty izc+jw/MuzxEhnIVeHQC5ZBYBibTmmEmBWaE8UGzTH7didZl6mOfYdwus6iqoTfP YBUWf6HxaKS6qyHwtPbUv6wY+aKb3t1EMu0L+1FWeZk8VBKOrJbR5Oho8ghV+5I= =18Bt -----END PGP SIGNATURE----- --onwk0SivC/dtQkFp--