From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761365AbcAKQ61 (ORCPT ); Mon, 11 Jan 2016 11:58:27 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:60457 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761330AbcAKQ6N (ORCPT ); Mon, 11 Jan 2016 11:58:13 -0500 Date: Mon, 11 Jan 2016 11:58:08 -0500 From: Damien Riegel To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Wolfgang Grandegger , Marc Kleine-Budde , kernel@savoirfairelinux.com Subject: Re: [PATCH v2 0/3] can: sja1000: support for technologic version Message-ID: <20160111165807.GA7116@localhost> References: <1450978973-30417-1-git-send-email-damien.riegel@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450978973-30417-1-git-send-email-damien.riegel@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, On Thu, Dec 24, 2015 at 12:42:50PM -0500, Damien Riegel wrote: > This patchset introduces support for the technologic version of the > SJA1000. Access to IP's registers are proxied through a window, > requiring two bus accesses to read or write a register. These accesses > must be protected by a spinlock to prevent race conditions. Currently, > there is no easy way to allocate and initialize this spinlock. > > SJA1000 already provides a way to allocate private data, but > sja1000_platform.c makes no use of it. > > Patch 1 adds the capability to allocate and initialize private data on a > per-compatible basis in sja1000_platform.c. > > Patch 2 updates device tree documentation to add the technologic > version. > > Patch 3 updates the driver to implement the technologic version > Did you have a chance to take a look at this patchset? I would appreciate your feedback, especially on the first patch. Thanks, Damien