* [PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init
@ 2016-01-11 3:37 Jia-Ju Bai
2016-01-11 16:21 ` Michael Büsch
2016-01-11 16:42 ` Rafał Miłecki
0 siblings, 2 replies; 3+ messages in thread
From: Jia-Ju Bai @ 2016-01-11 3:37 UTC (permalink / raw)
To: kvalo, zajec5, joe, davem, m, johannes.berg
Cc: linux-wireless, b43-dev, netdev, linux-kernel, Jia-Ju Bai
The memory allocated by kzalloc in b43_bus_dev_ssb_init is not freed.
This patch fixes the bug by adding kfree in b43_ssb_remove.
Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
drivers/net/wireless/b43/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index ec013fb..6d251a0 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -5798,6 +5798,7 @@ static void b43_ssb_remove(struct ssb_device *sdev)
b43_leds_unregister(wl);
b43_wireless_exit(dev, wl);
+ kfree(dev);
}
static struct ssb_driver b43_ssb_driver = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init
2016-01-11 3:37 [PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init Jia-Ju Bai
@ 2016-01-11 16:21 ` Michael Büsch
2016-01-11 16:42 ` Rafał Miłecki
1 sibling, 0 replies; 3+ messages in thread
From: Michael Büsch @ 2016-01-11 16:21 UTC (permalink / raw)
To: Jia-Ju Bai
Cc: kvalo, zajec5, joe, davem, johannes.berg, linux-wireless, b43-dev,
netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Mon, 11 Jan 2016 11:37:36 +0800
Jia-Ju Bai <baijiaju1990@163.com> wrote:
> The memory allocated by kzalloc in b43_bus_dev_ssb_init is not freed.
> This patch fixes the bug by adding kfree in b43_ssb_remove.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
> ---
> drivers/net/wireless/b43/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index ec013fb..6d251a0 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -5798,6 +5798,7 @@ static void b43_ssb_remove(struct ssb_device *sdev)
>
> b43_leds_unregister(wl);
> b43_wireless_exit(dev, wl);
> + kfree(dev);
> }
>
> static struct ssb_driver b43_ssb_driver = {
Nice catch.
The kfree is also missing in b43_bcma_remove().
And also in the error paths of b43_bcma_probe().
Can you please extend the patch to cover these, too?
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init
2016-01-11 3:37 [PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init Jia-Ju Bai
2016-01-11 16:21 ` Michael Büsch
@ 2016-01-11 16:42 ` Rafał Miłecki
1 sibling, 0 replies; 3+ messages in thread
From: Rafał Miłecki @ 2016-01-11 16:42 UTC (permalink / raw)
To: Jia-Ju Bai
Cc: Kalle Valo, Joe Perches, David Miller, Michael Büsch,
Johannes Berg, linux-wireless@vger.kernel.org, b43-dev,
Network Development, Linux Kernel Mailing List
On 11 January 2016 at 04:37, Jia-Ju Bai <baijiaju1990@163.com> wrote:
> The memory allocated by kzalloc in b43_bus_dev_ssb_init is not freed.
> This patch fixes the bug by adding kfree in b43_ssb_remove.
Nice. If you want somethig more to scratch your head, see
"Missing b43 firmware handling"
http://lists.infradead.org/pipermail/b43-dev/2014-June/003467.html
--
Rafał
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-11 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-11 3:37 [PATCH] b43: Fix a memory leak in b43_bus_dev_ssb_init Jia-Ju Bai
2016-01-11 16:21 ` Michael Büsch
2016-01-11 16:42 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox