From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762060AbcALBb1 (ORCPT ); Mon, 11 Jan 2016 20:31:27 -0500 Received: from tex.lwn.net ([70.33.254.29]:49784 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761913AbcALBbZ (ORCPT ); Mon, 11 Jan 2016 20:31:25 -0500 Date: Mon, 11 Jan 2016 18:31:22 -0700 From: Jonathan Corbet To: Robert Elliott Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, matt@codeblueprint.co.uk, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Documentation/kernel-parameters: update KMG units Message-ID: <20160111183122.1f7e5728@lwn.net> In-Reply-To: <1450917496-4023-1-git-send-email-elliott@hpe.com> References: <1450917496-4023-1-git-send-email-elliott@hpe.com> Organization: LWN.net X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Dec 2015 18:38:16 -0600 Robert Elliott wrote: > Since commit e004f3c7780d ("lib/cmdline.c: add size unit t/p/e to > memparse") expanded memparse() to support T, P, and E units in addition > to K, M, and G, all the kernel parameters that use that function became > capable of more than [KMG] mentioned in kernel-parameters.txt. > > Expand the introduction to the units and change all existing [KMG] > descriptions to [KMGTPE]. cma only had [MG]; reservelow only had [K]. > > Add [KMGTPE] for hugepagesz and memory_corruption_check_size, which also > use memparse(). > > Update two source code files with comments mentioning [KMG]. So I've ended up dropping this one from the docs tree for now. In the end, I just didn't want my pull request to include an explanation for why the docs tree has a conflict on mm/page_alloc.c.... The change is good, though, and shouldn't be lost. I'd say that either (1) Andrew can pick it up and merge it with the other stuff he has, or (2) we can push it through after mm has cleared. Either way, a version based on -mm would be a good thing to have. Thanks, jon