From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934666AbcAKUEz (ORCPT ); Mon, 11 Jan 2016 15:04:55 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:49653 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757521AbcAKUEx (ORCPT ); Mon, 11 Jan 2016 15:04:53 -0500 Date: Mon, 11 Jan 2016 12:04:50 -0800 From: Guenter Roeck To: Tony Lindgren Cc: Tomeu Vizoso , Russell King , Kevin Hilman , linux-arm-kernel@lists.infradead.org, "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: Re: arm qemu boot failures in -next due to 'PM / Domains: add setter for dev.pm_domain' Message-ID: <20160111200450.GA16902@roeck-us.net> References: <5693EB8A.40802@roeck-us.net> <20160111185459.GZ12777@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160111185459.GZ12777@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2016 at 10:55:00AM -0800, Tony Lindgren wrote: > * Guenter Roeck [160111 09:51]: > > Hi, > > > > I see 6 out of 24 arm qemu tests failing in next-20160111. Bisect points > > to commit 989561de9b51 ("PM / Domains: add setter for dev.pm_domain"). > > Failures are silent - there is no output on the console. > > Affected tests are > > > > arm:beagle:multi_v7_defconfig:omap3-beagle > > arm:beaglexm:multi_v7_defconfig:omap3-beagle-xm > > arm:overo:multi_v7_defconfig:omap3-overo-tobi > > arm:beagle:omap2plus_defconfig:omap3-beagle > > arm:beaglexm:omap2plus_defconfig:omap3-beagle-xm > > arm:overo:omap2plus_defconfig:omap3-overo-tobi > > > > For details please see the 'next' column at http://server.roeck-us.net:8010/builders. > > > > Reverting the offending commit fixes the problems. > > > > Please let me know if there is anything I can do to help tracking down the problem. > > The following fixes the booting, but I wonder if it's a Yes, it does. Tested-by: Guenter Roeck > proper fix? > That I don't know. Guenter > --- a/drivers/base/power/common.c > +++ b/drivers/base/power/common.c > @@ -145,9 +145,10 @@ void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd) > { > if (dev->pm_domain == pd) > return; > - > - WARN(device_is_bound(dev), > - "PM domains can only be changed for unbound devices\n"); > + if (device_is_registered(dev)) { > + WARN(device_is_bound(dev), > + "PM domains can only be changed for unbound devices\n"); > + } > dev->pm_domain = pd; > device_pm_check_callbacks(dev); > }