linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Darren Hart <dvhart@infradead.org>, Pavel Machek <pavel@ucw.cz>,
	ibm-acpi-devel@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Fabio D'Urso" <fabiodurso@hotmail.it>
Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight
Date: Mon, 11 Jan 2016 21:03:01 +0100	[thread overview]
Message-ID: <201601112103.01145@pali> (raw)
In-Reply-To: <1452540480.2848000.489039714.26068C20@webmail.messagingengine.com>

[-- Attachment #1: Type: Text/Plain, Size: 907 bytes --]

On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote
> The two features are not the same (and are handled differently by the
> firmware, for whatever reason), although they do serve the same
> purpose. I don't think a thinkpad will ever have both features at
> the same time, so I have no idea why they changed the firmware
> interface.

Maybe we should decide if ::kbd_backlight LED suffix could be used also 
for other LED devices and not only for those which are physically under 
the keyboard.

At least I understand "keyboard backlight" as light which is under the 
keyboard...

And more important, I was told that ThinkPad x230 comes in variant with 
both ThinkLight (that LED upper the display) and keyboard backlight 
(under they keyboard).

So I'm against merging ThinkLight and keyboard backlight to one sysfs 
path...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2016-01-11 20:03 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-24 18:46 [PATCH] thinkpad_acpi: Add support for keyboard backlight Pali Rohár
2015-12-27 23:14 ` Henrique de Moraes Holschuh
2015-12-28 14:48   ` Pali Rohár
2015-12-30 22:28     ` Pali Rohár
2016-01-06  8:45       ` Pali Rohár
2016-01-09 17:36         ` Henrique de Moraes Holschuh
2015-12-30 22:27 ` [PATCH v2] " Pali Rohár
2016-01-04 20:04   ` Darren Hart
2016-01-04 20:26     ` Pali Rohár
2016-01-04 20:40       ` Darren Hart
2016-01-04 20:51         ` Pali Rohár
2016-01-04 21:42           ` Darren Hart
2016-01-09 17:34         ` Henrique de Moraes Holschuh
2016-01-04 20:12 ` [PATCH] " Pavel Machek
2016-01-04 20:23   ` Pali Rohár
2016-01-04 20:40     ` Pali Rohár
2016-01-09 17:39   ` Henrique de Moraes Holschuh
2016-01-09 17:46     ` Henrique de Moraes Holschuh
2016-01-11 19:04       ` Darren Hart
2016-01-11 19:28         ` Henrique de Moraes Holschuh
2016-01-11 20:03           ` Pali Rohár [this message]
2016-01-11 21:12             ` Johannes Stezenbach
2016-01-12 16:07               ` Henrique de Moraes Holschuh
2016-01-12 16:23                 ` [ibm-acpi-devel] " Yves-Alexis Perez
2016-01-12 16:35                 ` Johannes Stezenbach
2016-01-12 17:56                   ` Henrique de Moraes Holschuh
2016-01-12 22:07                     ` Johannes Stezenbach
2016-01-12 18:11                 ` [ibm-acpi-devel] " Kevin Locke
2016-01-12 18:20                   ` Henrique de Moraes Holschuh
2016-01-12 18:36                     ` Kevin Locke
2016-01-12 16:04             ` Henrique de Moraes Holschuh
2016-01-12 21:58             ` Pavel Machek
2016-01-13  8:54               ` Pali Rohár
2016-01-13 19:07                 ` Pavel Machek
2016-01-13 19:10                   ` Pavel Machek
2016-01-21  8:57                     ` Pali Rohár
2016-01-11 22:44           ` [ibm-acpi-devel] " Yves-Alexis Perez
2016-01-12 16:59           ` Darren Hart
2016-01-12 17:51             ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201601112103.01145@pali \
    --to=pali.rohar@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=fabiodurso@hotmail.it \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).