From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934654AbcAKUDG (ORCPT ); Mon, 11 Jan 2016 15:03:06 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:38581 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934638AbcAKUDE (ORCPT ); Mon, 11 Jan 2016 15:03:04 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Henrique de Moraes Holschuh Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Date: Mon, 11 Jan 2016 21:03:01 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-71-generic; KDE/4.14.2; x86_64; ; ) Cc: Darren Hart , Pavel Machek , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <20160111190411.GE10643@malice.jf.intel.com> <1452540480.2848000.489039714.26068C20@webmail.messagingengine.com> In-Reply-To: <1452540480.2848000.489039714.26068C20@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1953989.BUkrITcQSi"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201601112103.01145@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1953989.BUkrITcQSi Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > The two features are not the same (and are handled differently by the > firmware, for whatever reason), although they do serve the same > purpose. I don't think a thinkpad will ever have both features at > the same time, so I have no idea why they changed the firmware > interface. Maybe we should decide if ::kbd_backlight LED suffix could be used also=20 for other LED devices and not only for those which are physically under=20 the keyboard. At least I understand "keyboard backlight" as light which is under the=20 keyboard... And more important, I was told that ThinkPad x230 comes in variant with=20 both ThinkLight (that LED upper the display) and keyboard backlight=20 (under they keyboard). So I'm against merging ThinkLight and keyboard backlight to one sysfs=20 path... =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1953989.BUkrITcQSi Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlaUCnUACgkQi/DJPQPkQ1KdngCcCdNG7RIcdOiSBPDyrQluTfzF tnUAnjts7lfUt4uYuJ+dn1JY1Bczfg7O =i71w -----END PGP SIGNATURE----- --nextPart1953989.BUkrITcQSi--