From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933413AbcAKVMq (ORCPT ); Mon, 11 Jan 2016 16:12:46 -0500 Received: from mail.sig21.net ([80.244.240.74]:38050 "EHLO mail.sig21.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbcAKVMo (ORCPT ); Mon, 11 Jan 2016 16:12:44 -0500 Date: Mon, 11 Jan 2016 22:12:28 +0100 From: Johannes Stezenbach To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Henrique de Moraes Holschuh , Darren Hart , Pavel Machek , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Message-ID: <20160111211228.GA4171@sig21.net> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <20160111190411.GE10643@malice.jf.intel.com> <1452540480.2848000.489039714.26068C20@webmail.messagingengine.com> <201601112103.01145@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201601112103.01145@pali> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-21-Score: -2.9 (--) X-Spam-21-Report: No, score=-2.9 required=8.0 tests=ALL_TRUSTED=-1,BAYES_00=-1.9 autolearn=ham Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2016 at 09:03:01PM +0100, Pali Rohár wrote: > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > The two features are not the same (and are handled differently by the > > firmware, for whatever reason), although they do serve the same > > purpose. I don't think a thinkpad will ever have both features at > > the same time, so I have no idea why they changed the firmware > > interface. ... > And more important, I was told that ThinkPad x230 comes in variant with > both ThinkLight (that LED upper the display) and keyboard backlight > (under they keyboard). I can confirm this, my x230 has both. FWIW, BIOS hotkey Fn+Space cycles through off, dim backlight, full backlight and full thinklight. /sys/class/leds/tpacpi::thinklight/brightness can be read (showing either 0 or 255) but writes are ignored. Dito for /proc/acpi/ibm/light. Johannes