From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934179AbcAKVmv (ORCPT ); Mon, 11 Jan 2016 16:42:51 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:45497 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757551AbcAKVmu (ORCPT ); Mon, 11 Jan 2016 16:42:50 -0500 Date: Mon, 11 Jan 2016 22:42:47 +0100 From: Pavel Machek To: "Andrew F. Davis" Cc: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, a.hajda@samsung.com Subject: Re: /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4? Message-ID: <20160111214247.GA9735@amd> References: <20160109230709.GA30551@amd> <5693BB75.70409@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5693BB75.70409@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > >Did /sys/class/power_supply/bq27200-0/capacity change meaning between > >4.1 and 4.4? > There was a resent overhaul of this driver and a lot of code is > vestigial as you have seen. I've been meaning to continue > cleaning it up, my next step would probably to bring up regmap Ok, 1wire is probably reasonable approach. But we have an regression between 4.1 and 4.4, and to debug it is probably by reading code. I can't prove you caused the regression, but you basically rewrote the driver, so it should be easier for you to spot the bug. n900 has this variant: bq27200: bq27200@55 { compatible = "ti,bq27200"; reg = <0x55>; }; Will you try? If not, tell me, and I can do it, but it will involve a lot of swaring... Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html