From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761122AbcAKWHW (ORCPT ); Mon, 11 Jan 2016 17:07:22 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:40542 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761028AbcAKWHO (ORCPT ); Mon, 11 Jan 2016 17:07:14 -0500 Date: Mon, 11 Jan 2016 23:07:09 +0100 From: Peter Zijlstra To: Juri Lelli Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org, mturquette@baylibre.com, steve.muckle@linaro.org, vincent.guittot@linaro.org, morten.rasmussen@arm.com, dietmar.eggemann@arm.com Subject: Re: [RFC PATCH 04/19] cpufreq: bring data structures close to their locks Message-ID: <20160111220708.GK6344@twins.programming.kicks-ass.net> References: <1452533760-13787-1-git-send-email-juri.lelli@arm.com> <1452533760-13787-5-git-send-email-juri.lelli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452533760-13787-5-git-send-email-juri.lelli@arm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2016 at 05:35:45PM +0000, Juri Lelli wrote: > +/** > + * Iterate over governors > + * > + * cpufreq_governor_list is protected by cpufreq_governor_mutex. > + */ > +static LIST_HEAD(cpufreq_governor_list); > +static DEFINE_MUTEX(cpufreq_governor_mutex); > +#define for_each_governor(__governor) \ > + list_for_each_entry(__governor, &cpufreq_governor_list, governor_list) So you could stuff the lockdep_assert_held() you later add intididually into the for_each_governor macro, impossible to forget that way.