From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760962AbcAKWkA (ORCPT ); Mon, 11 Jan 2016 17:40:00 -0500 Received: from mail.kernel.org ([198.145.29.136]:55217 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760604AbcAKWj6 (ORCPT ); Mon, 11 Jan 2016 17:39:58 -0500 Date: Mon, 11 Jan 2016 19:39:54 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, netdev@vger.kernel.org, davem@davemloft.net, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH 05/53] perf tools: Test correct path of perf in build-test Message-ID: <20160111223954.GM18367@kernel.org> References: <1452520124-2073-1-git-send-email-wangnan0@huawei.com> <1452520124-2073-6-git-send-email-wangnan0@huawei.com> <20160111152456.GC18367@kernel.org> <20160111220618.GK18367@kernel.org> <20160111223904.GL18367@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160111223904.GL18367@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jan 11, 2016 at 07:39:04PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Jan 11, 2016 at 07:06:18PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Jan 11, 2016 at 12:24:56PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Mon, Jan 11, 2016 at 01:47:56PM +0000, Wang Nan escreveu: > > > > If an 'O' is passed to 'make build-test', many 'test -x' and 'test -f' > > > > will fail because perf resides in a different directory. Fix this by > > > > computing PERF_OUT according to 'O' and test correct output files. > > > > For make_kernelsrc and make_kernelsrc_tools, set KBUILD_OUTPUT_DIR > > > > instead because the path is different from others ($(O)/perf vs > > > > $(O)/tools/perf). > > > > > > Ok, applying up to this patch I now manage to almost cleanly build it using O=, > > > see below, but seems that we have some race, as not all tests end up producing > > > such warnings. > > > > > > [acme@felicio linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make O=/tmp/build/perf -C tools/perf build-test > > > make: Entering directory `/home/acme/git/linux/tools/perf' > > > Testing Makefile > > > - make_no_libperl: cd . && make -f Makefile DESTDIR=/tmp/tmp.m1nXBMqhSA NO_LIBPERL=1 > > > find: ‘/tmp/build/perf/util/trace-event-scripting.o’: No such file or directory > > > > Well, it is happening even without O=: > > So I removed a few patches and those aren't appearing anymore, please > take a look at my perf/core branch, running build-test on a few machines > now, will push soon. > > My hunch is that build-test has issues with parallel builds, but I'm not > sure... Good: - make_perf_o_O: cd . && make -f Makefile O=/tmp/tmp.oLeg8aUaOo DESTDIR=/tmp/tmp.16WP4HTQJs perf.o - make_util_pmu_bison_o_O: cd . && make -f Makefile O=/tmp/tmp.xNRV0pCXfD DESTDIR=/tmp/tmp.8dyU9uEbHe util/pmu-bison.o - make_no_libdw_dwarf_unwind_O: cd . && make -f Makefile O=/tmp/tmp.pHH4HExHcH DESTDIR=/tmp/tmp.Wo0m8fF5cp NO_LIBDW_DWARF_UNWIND=1 - make_no_demangle_O: cd . && make -f Makefile O=/tmp/tmp.yWNsd4jOsI DESTDIR=/tmp/tmp.Q7eA4kCvwL NO_DEMANGLE=1 - tarpkg: ./tests/perf-targz-src-pkg . - make -C tools/perf - make -C /tools perf OK