From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934471AbcALIpu (ORCPT ); Tue, 12 Jan 2016 03:45:50 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37054 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934450AbcALIpr (ORCPT ); Tue, 12 Jan 2016 03:45:47 -0500 Date: Tue, 12 Jan 2016 08:45:43 +0000 From: Lee Jones To: Wenyou Yang Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Javier Martinez Canillas , Krzysztof Kozlowski , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver Message-ID: <20160112084543.GP19803@x1> References: <1452585915-551-1-git-send-email-wenyou.yang@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1452585915-551-1-git-send-email-wenyou.yang@atmel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jan 2016, Wenyou Yang wrote: > This patch set adds support for the Active-semi ACT8945A PMIC > MFD driver. It is a Multi Function Device with the following > subdevices: > - Regulator > - Charger > > It is interfaced to the host controller using I2C interface, > ACT8945A is a child device of the I2C. > > Changes in v2: > - add more help information in Kconfig. > - update the file header with short version license and author line. > - remove unused structure members (dev, i2c_client) of stuct act8945a_dev. > - use define "PLATFORM_DEVID_NONE" for mfd_add_devices(), instead of '-1'. > - use more explicit info to indicate the failure to add sub devices. > - remove the unnecessary print out. > - substitute MODULE_LICENSE("GPL") for MODULE_LICENSE("GPL v2"). > - use more specific label in Example. > - add pmic and charger nodes in Example. > > Wenyou Yang (2): > mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver > mfd: add documentation for ACT8945A DT bindings Sending out 3 patch-sets for related changes is a pretty unconventional way of doing things. In future could you place them all in the same place, that way all of the patches stay together whist hopping around our inboxes. > Documentation/devicetree/bindings/mfd/act8945a.txt | 82 +++++++++++++++ > drivers/mfd/Kconfig | 11 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/act8945a.c | 109 ++++++++++++++++++++ > include/linux/mfd/act8945a.h | 21 ++++ > 5 files changed, 224 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt > create mode 100644 drivers/mfd/act8945a.c > create mode 100644 include/linux/mfd/act8945a.h > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog