From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934364AbcALIyB (ORCPT ); Tue, 12 Jan 2016 03:54:01 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35781 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934172AbcALIx7 (ORCPT ); Tue, 12 Jan 2016 03:53:59 -0500 Date: Tue, 12 Jan 2016 08:53:55 +0000 From: Lee Jones To: "Yang, Wenyou" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Ferre, Nicolas" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Message-ID: <20160112085355.GR19803@x1> References: <1452218729-11357-1-git-send-email-wenyou.yang@atmel.com> <1452218729-11357-3-git-send-email-wenyou.yang@atmel.com> <20160111054908.GE3331@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jan 2016, Yang, Wenyou wrote: > Hi Lee, > > > -----Original Message----- > > From: Lee Jones [mailto:lee.jones@linaro.org] > > Sent: 2016年1月11日 13:49 > > To: Yang, Wenyou > > Cc: Rob Herring ; Pawel Moll ; > > Mark Rutland ; Ian Campbell > > ; Kumar Gala ; Ferre, > > Nicolas ; linux-kernel@vger.kernel.org; > > devicetree@vger.kernel.org > > Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings > > > > On Fri, 08 Jan 2016, Wenyou Yang wrote: > > > > > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two > > > subdevices: > > > - Regulator > > > - Charger > > > > Is this really an MFD? What special handling does it require? > > Yes, this is an MFD, two sub devices: regulators and charger. > > > > > > This patch adds documentation for ACT8945A DT bindings. > > > > > > Signed-off-by: Wenyou Yang > > > --- > > > > > > Documentation/devicetree/bindings/mfd/act8945a.txt | 16 > > ++++++++++++++++ > > > 1 file changed, 16 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt > > > b/Documentation/devicetree/bindings/mfd/act8945a.txt > > > new file mode 100644 > > > index 0000000..406db16 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt > > > @@ -0,0 +1,16 @@ > > > +Device-Tree bindings for Active-semi ACT8945A MFD driver > > > + > > > +Required properties: > > > + - compatible: "active-semi,act8945a". > > > + - reg: the I2C slave address for the ACT8945A chip > > > + > > > +The chip exposes two subdevices: > > > + - a regulators: see ../regulator/act8945a-regulator.txt > > > + - a charger: see ../power/act8945a-charger.txt > > > + > > > +Example: > > > + mfd: act8945a@5b { > > > > "mfd" is too generic to be a label. > > > > Why do you need a label in any case? > > Remove the mfd, use act8945a@5b. Use pmic@5b > > > + compatible = "active-semi,act8945a"; > > > + reg = <0x5b>; > > > + status = "okay"; > > > + }; > > > > This doesn't look much like an MFD to me. > > I will add the child nodes for its sub devices, inclusive pmic and charger nodes. Very well. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog