From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964838AbcALJQt (ORCPT ); Tue, 12 Jan 2016 04:16:49 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:34584 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934573AbcALJQq (ORCPT ); Tue, 12 Jan 2016 04:16:46 -0500 Date: Tue, 12 Jan 2016 09:16:43 +0000 From: Lee Jones To: Arnd Bergmann Cc: Linus Walleij , Paul Parsons , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mfd: asic3: remove extraneous ')' Message-ID: <20160112091643.GA27358@x1> References: <5507931.oM3h7nKshR@wuerfel> <20160112091606.GV19803@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160112091606.GV19803@x1> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jan 2016, Lee Jones wrote: > On Tue, 12 Jan 2016, Arnd Bergmann wrote: > > A cleanup patch introduced an extra closing ')' that leads to a > > build error: > > > > drivers/mfd/asic3.c: In function 'asic3_gpio_get': > > drivers/mfd/asic3.c:505:12: error: expected ';' before ')' token > > > > This removes the extra character to get it to build again. > > > > Signed-off-by: Arnd Bergmann > > Fixes: fd5b4d01a638 ("mfd: asic3: Be sure to clamp return value") > > --- > > This came up today on linux-next. I took the liberty to adjust formatting > > of that line as well, if you prefer the original line wrapping please > > undo that part when applying. > > Please ignore MFD in next, as it's not quite ready. I've been on > vacation for 4 weeks and only returned to work yesterday. I am > currently running MFD through AIAIAI and will fix-up any issues I > find. As for you Linus. Tut tut. ;) > > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c > > index c8d46e51faf1..4dca6bc61f5b 100644 > > --- a/drivers/mfd/asic3.c > > +++ b/drivers/mfd/asic3.c > > @@ -501,8 +501,8 @@ static int asic3_gpio_get(struct gpio_chip *chip, > > return -EINVAL; > > } > > > > - return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) > > - & mask)); > > + return !!(asic3_read_register(asic, > > + gpio_base + ASIC3_GPIO_STATUS) & mask); > > } > > > > static void asic3_gpio_set(struct gpio_chip *chip, > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog