From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763396AbcALSoc (ORCPT ); Tue, 12 Jan 2016 13:44:32 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34357 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762023AbcALSoa (ORCPT ); Tue, 12 Jan 2016 13:44:30 -0500 Date: Tue, 12 Jan 2016 10:44:37 -0800 From: Stephen Hemminger To: Jamal Hadi Salim Cc: Lubomir Rintel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 1/3] ifb: make device count build-time configurable Message-ID: <20160112104437.0e1a841b@xeon-e3> In-Reply-To: <5694F7BA.3040402@mojatatu.com> References: <1452599804-27284-1-git-send-email-lkundrak@v3.sk> <5694F7BA.3040402@mojatatu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jan 2016 07:55:22 -0500 Jamal Hadi Salim wrote: > On 16-01-12 06:56 AM, Lubomir Rintel wrote: > > The devices can be created at run-time for quite some time already and the > > load-time device creation collides with attempts to create the device of > > the same name: > > > > # rmmod ifb > > # ip link add ifb0 type ifb > > RTNETLINK answers: File exists > > > > This is pretty much the same situation as was with the block loop devices > > which was solved by adding a build-time configuration that the > > distributions could use as they deem fit while keeping the default for > > compatibility. > > > > Let's do that here as well. > > > > Signed-off-by: Lubomir Rintel > > I guess module options are frowned upon. so: I would prefer that this were done with a module parameter, the same as dummy. Only developers build their own configured kernels. Having the value set later at module load time is preferable.