From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
Borislav Petkov <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/x86: Disable ldt_gdt_64 for now
Date: Tue, 12 Jan 2016 11:45:44 +0100 [thread overview]
Message-ID: <20160112104544.GA7121@gmail.com> (raw)
In-Reply-To: <CALCETrVhLMT7qS-Tf9-dpcKuqspek1TbrGxL8qPhW4ft2_b7Mw@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> On Mon, Jan 11, 2016 at 2:59 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Shuah Khan <shuahkh@osg.samsung.com> wrote:
> >
> >> On 01/06/2016 12:51 PM, Andy Lutomirski wrote:
> >> > ldt_gdt.c relies on cross-cpu invalidation of SS to do one of its
> >> > tests. On 32-bit builds, this works fine, but on 64-bit builds, it
> >> > only works if the kernel has proper SS sigcontext handling for
> >> > 64-bit user programs.
> >> >
> >> > Since the SS fixes are currently reverted, restrict the test case to
> >> > 32 bits for now.
> >> >
> >> > In principle, I could change the test to use a different segment
> >> > register, but it would be messy: CS can't point to the LDT for
> >> > 64-bit code, and the other registers don't result in immediate
> >> > faults because they aren't reloaded on kernel -> user transitions.
> >> >
> >> > When we fix sigcontext (in 4.6?), we can revert this.
> >> >
> >> > Signed-off-by: Andy Lutomirski <luto@kernel.org>
> >> > --
> >>
> >> Andy,
> >>
> >> This patch didn't apply to linux-kselftest next.
> >> It probably has to go through x86.
> >
> > It doesn't apply to -tip either. Andy, which tree is this against?
>
> Oops, it applies on top of a new self-test that I forgot to send. I
> send a v2 that should be better. I'll send the new selftest out as
> well once -tip catches up with all the vdso patches.
Ok, sounds great!
Thanks,
Ingo
prev parent reply other threads:[~2016-01-12 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 19:51 [PATCH] selftests/x86: Disable ldt_gdt_64 for now Andy Lutomirski
2016-01-07 20:49 ` Shuah Khan
2016-01-11 10:59 ` Ingo Molnar
2016-01-12 1:25 ` Andy Lutomirski
2016-01-12 10:45 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112104544.GA7121@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).