From: Mark Rutland <mark.rutland@arm.com>
To: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Zhaoyang Huang (黄朝阳)" <zhaoyang.huang@spreadtrum.com>
Cc: Zhaoyang Huang <zhaoyang.huang@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
Hanjun Guo <hanjun.guo@linaro.org>,
suzuki.poulose@arm.com
Subject: Re: [RFC PATCH v2] Add IPI entry for CPU UP
Date: Tue, 12 Jan 2016 11:51:04 +0000 [thread overview]
Message-ID: <20160112115104.GB4858@leverpostej> (raw)
In-Reply-To: <20160112093820.GA3601@red-moon>
On Tue, Jan 12, 2016 at 09:38:20AM +0000, Lorenzo Pieralisi wrote:
> On Tue, Jan 12, 2016 at 10:17:42AM +0800, Zhaoyang Huang wrote:
> > On 12 January 2016 at 10:05, Zhaoyang Huang <zhaoyang.huang@linaro.org> wrote:
> > > In some ARM SOCs, IPI interrupt is used for hotplug in one cpu, that is,
> > > sending a IPI to the core in WFI and powerdown status. So Add a IPI
> > > entry for handle this kind of cpu up interrupt
> > > Launching the IPI can be done within PSCI, while there will be one unknown
> > > type of IPI as the dest core come up to the kernel world which will bring a
> > > warning so far.So add such type of IPI to handle the interrupt.
>
> You missed CC'ing ALKML for the second time and you were warned.
>
> You are adding a call to *send* an IPI in the kernel so the commit
> above is misleading.
>
> Acknowledge and clear the IRQ in FW so that the mechanism is completely
> implemented in FW (ie PSCI), that the CPU coming out of reset will run
> before getting to the kernel, this patch is not needed and we already
> explained to you why.
>
> Lorenzo
I would also suggest that FW used the set of SGIs reserved for secure
usage (i.e. ID8 - ID15), as these will not conflict with those the
kernel uses.
Thanks,
Mark.
next prev parent reply other threads:[~2016-01-12 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 2:05 [RFC PATCH v2] Add IPI entry for CPU UP Zhaoyang Huang
2016-01-12 2:17 ` Zhaoyang Huang
2016-01-12 9:38 ` Lorenzo Pieralisi
2016-01-12 9:42 ` Zhaoyang Huang
2016-01-12 11:51 ` Mark Rutland [this message]
2016-01-21 8:48 ` Zhaoyang Huang
2016-01-21 10:51 ` Mark Rutland
2016-01-22 2:01 ` Zhaoyang Huang
2016-01-22 8:07 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112115104.GB4858@leverpostej \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=hanjun.guo@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
--cc=zhaoyang.huang@linaro.org \
--cc=zhaoyang.huang@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox