From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1761058AbcALLv2 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 06:51:28 -0500
Received: from foss.arm.com ([217.140.101.70]:33777 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752252AbcALLv0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 06:51:26 -0500
Date: Tue, 12 Jan 2016 11:51:04 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Zhaoyang Huang =?utf-8?B?KOm7hOacnemYsyk=?= 
	<zhaoyang.huang@spreadtrum.com>
Cc: Zhaoyang Huang <zhaoyang.huang@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>, will.deacon@arm.com,
        linux-kernel@vger.kernel.org, Hanjun Guo <hanjun.guo@linaro.org>,
        suzuki.poulose@arm.com
Subject: Re: [RFC PATCH v2] Add IPI entry for CPU UP
Message-ID: <20160112115104.GB4858@leverpostej>
References: <1452564312-1265-1-git-send-email-zhaoyang.huang@spreadtrum.com>
 <CAN2waFuaVesBB6SSpuQ8-_bF0hZ1C56NX=CR5z06ytVLccnnbA@mail.gmail.com>
 <20160112093820.GA3601@red-moon>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160112093820.GA3601@red-moon>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 12, 2016 at 09:38:20AM +0000, Lorenzo Pieralisi wrote:
> On Tue, Jan 12, 2016 at 10:17:42AM +0800, Zhaoyang Huang wrote:
> > On 12 January 2016 at 10:05, Zhaoyang Huang <zhaoyang.huang@linaro.org> wrote:
> > > In some ARM SOCs, IPI interrupt is used for hotplug in one cpu, that is,
> > > sending a IPI to the core in WFI and powerdown status. So Add a IPI
> > > entry for handle this kind of cpu up interrupt
> > > Launching the IPI can be done within PSCI, while there will be one unknown
> > > type of IPI as the dest core come up to the kernel world which will bring a
> > > warning so far.So add such type of IPI to handle the interrupt.
> 
> You missed CC'ing ALKML for the second time and you were warned.
> 
> You are adding a call to *send* an IPI in the kernel so the commit
> above is misleading.
> 
> Acknowledge and clear the IRQ in FW so that the mechanism is completely
> implemented in FW (ie PSCI), that the CPU coming out of reset will run
> before getting to the kernel, this patch is not needed and we already
> explained to you why.
> 
> Lorenzo

I would also suggest that FW used the set of SGIs reserved for secure
usage (i.e. ID8 - ID15), as these will not conflict with those the
kernel uses.

Thanks,
Mark.