From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762681AbcALPCH (ORCPT ); Tue, 12 Jan 2016 10:02:07 -0500 Received: from verein.lst.de ([213.95.11.211]:38429 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283AbcALPCF (ORCPT ); Tue, 12 Jan 2016 10:02:05 -0500 Date: Tue, 12 Jan 2016 16:02:00 +0100 From: Christoph Hellwig To: "Nicholas A. Bellinger" Cc: target-devel , linux-scsi , lkml , Sagi Grimberg , Christoph Hellwig , Hannes Reinecke , Andy Grover , Vasu Dev , Vu Pham , Nicholas Bellinger Subject: Re: [PATCH-v2 1/4] tcm_fc: Convert acl lookup to modern get_initiator_node_acl usage Message-ID: <20160112150200.GA2058@lst.de> References: <1452457724-10629-1-git-send-email-nab@daterainc.com> <1452457724-10629-2-git-send-email-nab@daterainc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452457724-10629-2-git-send-email-nab@daterainc.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 10, 2016 at 08:28:41PM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch does a simple conversion of tcm_fc code to use > proper modern core_tpg_get_initiator_node_acl() lookup using > se_node_acl->acl_kref, and drops the legacy list walk from > ft_acl_get(). > > Note the original lookup also took node_name into account, > but since ft_init_nodeacl() only ever sets port_name for > se_node_acl->acl_group within configfs, this is purely > a mechanical change. Please remove ft_acl_get and fold it's new implementation into the caller. The later patches actually remove the usage of it but keep it around, but it would be much better to kill it off here.