From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 5/4] perf ui/tui: Print helpline message as is
Date: Tue, 12 Jan 2016 12:23:58 -0300 [thread overview]
Message-ID: <20160112152358.GD18367@kernel.org> (raw)
In-Reply-To: <1452509594-13616-1-git-send-email-namhyung@kernel.org>
Em Mon, Jan 11, 2016 at 07:53:14PM +0900, Namhyung Kim escreveu:
> When a tip message contains a percent sign, it was treated printf format
> specifier so broken string was printed like below.
>
> Tip: Limit to show entries above 577nly: perf report --percent-limit 5
> ^^^
>
> As ui_browser__show receives format string, pass additional "%s" so that
> the help (tip) message can be printed as is.
>
> Tip: Limit to show entries above 5% only: perf report --percent-limit 5
Applied.
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/ui/browsers/hists.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index 901d481e6cea..08c09ad755d2 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -480,7 +480,7 @@ static int hist_browser__run(struct hist_browser *browser, const char *help)
>
> hists__browser_title(browser->hists, hbt, title, sizeof(title));
>
> - if (ui_browser__show(&browser->b, title, help) < 0)
> + if (ui_browser__show(&browser->b, title, "%s", help) < 0)
> return -1;
>
> while (1) {
> --
> 2.6.4
next prev parent reply other threads:[~2016-01-12 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 10:16 [PATCH 1/4] perf tools: Add more usage tips Namhyung Kim
2016-01-09 10:16 ` [PATCH 2/4] perf tools: Add file_only config option to strlist Namhyung Kim
2016-01-13 9:42 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2016-01-09 10:16 ` [PATCH 3/4] perf tools: Set and pass DOCDIR to builtin-report.c Namhyung Kim
2016-01-13 9:42 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2016-01-09 10:16 ` [PATCH 4/4] perf tools: Fallback to srcdir/Documentation/tips.txt Namhyung Kim
2016-01-11 9:18 ` Jiri Olsa
2016-01-12 15:34 ` Arnaldo Carvalho de Melo
2016-01-12 15:39 ` Arnaldo Carvalho de Melo
2016-01-12 15:22 ` Arnaldo Carvalho de Melo
2016-01-13 9:43 ` [tip:perf/urgent] perf tools: Fallback to srcdir/Documentation/ tips.txt tip-bot for Namhyung Kim
2016-01-10 3:38 ` [PATCH 1/4] perf tools: Add more usage tips Andi Kleen
2016-01-11 10:35 ` [PATCH v2 " Namhyung Kim
2016-01-11 10:53 ` [PATCH 5/4] perf ui/tui: Print helpline message as is Namhyung Kim
2016-01-12 15:23 ` Arnaldo Carvalho de Melo [this message]
2016-01-13 9:42 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2016-01-13 9:41 ` [tip:perf/urgent] perf tools: Add more usage tips tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112152358.GD18367@kernel.org \
--to=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).