From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762794AbcALPYF (ORCPT ); Tue, 12 Jan 2016 10:24:05 -0500 Received: from mail.kernel.org ([198.145.29.136]:59076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752769AbcALPYC (ORCPT ); Tue, 12 Jan 2016 10:24:02 -0500 Date: Tue, 12 Jan 2016 12:23:58 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Andi Kleen , Wang Nan Subject: Re: [PATCH 5/4] perf ui/tui: Print helpline message as is Message-ID: <20160112152358.GD18367@kernel.org> References: <1452508510-28316-1-git-send-email-namhyung@kernel.org> <1452509594-13616-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452509594-13616-1-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jan 11, 2016 at 07:53:14PM +0900, Namhyung Kim escreveu: > When a tip message contains a percent sign, it was treated printf format > specifier so broken string was printed like below. > > Tip: Limit to show entries above 577nly: perf report --percent-limit 5 > ^^^ > > As ui_browser__show receives format string, pass additional "%s" so that > the help (tip) message can be printed as is. > > Tip: Limit to show entries above 5% only: perf report --percent-limit 5 Applied. > Signed-off-by: Namhyung Kim > --- > tools/perf/ui/browsers/hists.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c > index 901d481e6cea..08c09ad755d2 100644 > --- a/tools/perf/ui/browsers/hists.c > +++ b/tools/perf/ui/browsers/hists.c > @@ -480,7 +480,7 @@ static int hist_browser__run(struct hist_browser *browser, const char *help) > > hists__browser_title(browser->hists, hbt, title, sizeof(title)); > > - if (ui_browser__show(&browser->b, title, help) < 0) > + if (ui_browser__show(&browser->b, title, "%s", help) < 0) > return -1; > > while (1) { > -- > 2.6.4