From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762005AbcALPdG (ORCPT ); Tue, 12 Jan 2016 10:33:06 -0500 Received: from foss.arm.com ([217.140.101.70]:35283 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcALPdC (ORCPT ); Tue, 12 Jan 2016 10:33:02 -0500 Date: Tue, 12 Jan 2016 15:33:24 +0000 From: Juri Lelli To: Viresh Kumar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, peterz@infradead.org, rjw@rjwysocki.net, mturquette@baylibre.com, steve.muckle@linaro.org, vincent.guittot@linaro.org, morten.rasmussen@arm.com, dietmar.eggemann@arm.com Subject: Re: [RFC PATCH 07/19] cpufreq: assert locking when accessing cpufreq_governor_list Message-ID: <20160112153324.GB18734@e106622-lin> References: <1452533760-13787-1-git-send-email-juri.lelli@arm.com> <1452533760-13787-8-git-send-email-juri.lelli@arm.com> <20160112100122.GY1084@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160112100122.GY1084@ubuntu> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 12/01/16 15:31, Viresh Kumar wrote: > On 11-01-16, 17:35, Juri Lelli wrote: > > @@ -2025,6 +2027,7 @@ int cpufreq_register_governor(struct cpufreq_governor *governor) > > err = -EBUSY; > > if (!find_governor(governor->name)) { > > err = 0; > > + lockdep_assert_held(&cpufreq_governor_mutex); > > list_add(&governor->governor_list, &cpufreq_governor_list); > > } > > Why here? This is how the routine looks like: > I guess I was simply over-paranoid. We can drop this assertion. Thanks, - Juri > int cpufreq_register_governor(struct cpufreq_governor *governor) > { > int err; > > if (!governor) > return -EINVAL; > > if (cpufreq_disabled()) > return -ENODEV; > > mutex_lock(&cpufreq_governor_mutex); > > governor->initialized = 0; > err = -EBUSY; > if (!find_governor(governor->name)) { > err = 0; > list_add(&governor->governor_list, &cpufreq_governor_list); > } > > mutex_unlock(&cpufreq_governor_mutex); > return err; > } > > > -- > viresh >