From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753749AbcALQfe (ORCPT ); Tue, 12 Jan 2016 11:35:34 -0500 Received: from mail.sig21.net ([80.244.240.74]:47210 "EHLO mail.sig21.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbcALQfc (ORCPT ); Tue, 12 Jan 2016 11:35:32 -0500 Date: Tue, 12 Jan 2016 17:35:14 +0100 From: Johannes Stezenbach To: Henrique de Moraes Holschuh Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Darren Hart , Pavel Machek , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Message-ID: <20160112163514.GA24900@sig21.net> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <20160111190411.GE10643@malice.jf.intel.com> <1452540480.2848000.489039714.26068C20@webmail.messagingengine.com> <201601112103.01145@pali> <20160111211228.GA4171@sig21.net> <1452614830.376787.489968026.5FAEDB86@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452614830.376787.489968026.5FAEDB86@webmail.messagingengine.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-21-Score: -2.9 (--) X-Spam-21-Report: No, score=-2.9 required=8.0 tests=ALL_TRUSTED=-1,BAYES_00=-1.9 autolearn=ham Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2016 at 02:07:10PM -0200, Henrique de Moraes Holschuh wrote: > On Mon, Jan 11, 2016, at 19:12, Johannes Stezenbach wrote: > > > > I can confirm this, my x230 has both. FWIW, BIOS hotkey > > Fn+Space cycles through off, dim backlight, full backlight > > and full thinklight. /sys/class/leds/tpacpi::thinklight/brightness > > can be read (showing either 0 or 255) but writes are ignored. > > Dito for /proc/acpi/ibm/light. > > We likely need to integrate better (future work) the new backlight > control with the thinklight control and the firmware interface in the > x230. > > Is the ACPI AML for fn+space readable enough, or is it trapping directly > into SMM? Because if it interacts with the traditional higher-level > ACPI AML we already use to talk to the thinklight (and now to the > backlight), it should be relatively easy to fix the driver to better > support the x230. I have no clue about ACPI, do you have some hints how to get the info you want? I found this: sudo acpidump > acpidata.dat acpixtract -sSSDT acpidata.dat acpixtract -sDSDT acpidata.dat iasl -d DSDT.dat SSDT*.dat ..and then look at the .dsl files that contain the AML assembler. But what to look out for? PS: failed to mention my x230 kernel was still 4.2.x in case it matters Thanks, Johannes