From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753629AbcALQrH (ORCPT ); Tue, 12 Jan 2016 11:47:07 -0500 Received: from mail-by2on0077.outbound.protection.outlook.com ([207.46.100.77]:11168 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752311AbcALQrE (ORCPT ); Tue, 12 Jan 2016 11:47:04 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Tue, 12 Jan 2016 19:46:41 +0300 From: Yury Norov To: Arnd Bergmann CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c Message-ID: <20160112164641.GA9246@yury-N73SV> References: <1452209679-19445-1-git-send-email-ynorov@caviumnetworks.com> <1452209679-19445-12-git-send-email-ynorov@caviumnetworks.com> <5115829.mX1Uk4EoYk@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5115829.mX1Uk4EoYk@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: HE1PR03CA0033.eurprd03.prod.outlook.com (25.163.170.171) To DM2PR07MB622.namprd07.prod.outlook.com (10.141.177.146) X-Microsoft-Exchange-Diagnostics: 1;DM2PR07MB622;2:DWUf1Fnkze1fBLizdttjN3u2RzHMpEtn7fNU4hcohcsghC8uypKhVeYuYsYrxd0+UCfwofjYERf21IU2HI9Qx7R8CX6tAuVCChJ5ejbygLIrOU3z5DzzloJolmB0OO4m9iJhweJQP6+xzjac5H5Muw==;3:NVfi1A7halDwygbs7FTgknwX4nJWVxuoaMLumxYifTEQLImmr14KD/l4PgM0+N+z3XLpzGTWCQTkBBsvtdWi7N5RHOhVouotQcteELBcAuWU5KSr2pyZq7StJetElkLk;25:Jnc4nwozxqJhG+6UDqdRSRIRN5XJUnt9Jox6Qx+R1E307LVkaGi4zBXQXHRXQmUfYToJR6Yq4rzwN0toWbwobDAH22KnGuqQmS9Aayh7LdUI+EcaE9ksMszDJq7+8oHLa6Xn6LBao6+Pj9QyIrdxbH2HaU7kDog51uSEu80VlvgMky/dYl7/4qekOEZj30PfLHy2HY9I7OyGjM//EwMohUGrb3gU8HkexgiWz1eDqYCQtMrIe9nqxiZ8lF+kgOpq X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR07MB622; X-MS-Office365-Filtering-Correlation-Id: e2f4b622-76bf-4a39-2786-08d31b6ffefb X-Microsoft-Exchange-Diagnostics: 1;DM2PR07MB622;20:LwO84u3WdkyHfcANW4vyCvcQPJzPlc/jd1w/5FBtnM7kwmqMh/tafi1u2QfKE2bwZbCqxI+NWe9zcDZAd5KtGNnIFktr5BLB2c/YCkF40a6Sh1GOcuNNMR9OSiLrcDO32nXJFmHM2OmJGviYArrpKQUKy+d+1FYi1uq9ifBtz58AAivXeZHMWISPselTt3WuN9SEWv/HkLQZnbGxdrIvm84bvNzOUaTgXMQsMVyK06nupPrQMd4/0YqydLGgWC6pIxhGLp6xgf1reE29MP4ZWMBsPrVnlPpoUQI/F3TA+SwT5U5wGsFRUgwAXUPwxHYeCBtczHlavWPljlkrcKh9DM1ofASZjCzUpU5KjHZZ9rS/Y1k2j7X8/VFWYhydOeDuxTfGF/8avs9POcPMR1s8RSig8GuUznIMeYZsQYPssbOkrxqTbnF+zno35UaLzYFnDDRPrU5p5YweoaHhAGmzk6q5E3gLpGkf2kMfAlinVrwe4FCePJHsgaGy5Cw9hMoG9vCt8NYReElTYZJpTbUGaxPtRB5uNknvZP1vpWS6vXqThams1ShqG+kwBzqFYa6i4IUquYdpiUichsoRJpuYLGJTV+qufd1CJKX0jQIYoJo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:DM2PR07MB622;BCL:0;PCL:0;RULEID:;SRVR:DM2PR07MB622; X-Microsoft-Exchange-Diagnostics: 1;DM2PR07MB622;4:1ETHdtc5DlNg5FofHQWSOKsAXT8j40Grhykkuwl3sP0JQN2fG3cdmmr/BVqmXxjLI2ZvXQvViV4vxC8t9zGzZDEyjlXbIsrPXPmZx+Vl55eEI0jN3+UtXApei+sHu84W0kZfb5x/3h4J7BYCjtD9zyOR46nDfMt9H58jWbCihe4PQdq8ib5RdWfAZrorQSr4GGZD4o5jrPjAqTGYuKc/pgLdQouznEk9cFFWnpwciMWwZ0GHE87/Anyc9P5vsphz6b881LxILzPAIJFRGpIniFJHTWH4iScUDLfgpPqjdR2SMfh141HWnaMHSorHLsRtfv3Yk+m2stIbf4dnz9bjUwh370LjedhauavnYcGnsE0OHTOyfqypD+wWiYWyiI46 X-Forefront-PRVS: 081904387B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(24454002)(189002)(199003)(47776003)(42186005)(189998001)(105586002)(92566002)(5004730100002)(1096002)(87976001)(50986999)(1076002)(3846002)(2906002)(6116002)(50466002)(76506005)(5008740100001)(101416001)(4326007)(97756001)(40100003)(586003)(33656002)(97736004)(83506001)(76176999)(2950100001)(122386002)(110136002)(54356999)(23726003)(77096005)(106356001)(33716001)(46406003)(81156007)(66066001)(4001350100001)(5001960100002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR07MB622;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR07MB622;23:3K6YR78XE4W1XWQXJw4vQJ5l3V3fnMxYGv6cWscf/j?= =?us-ascii?Q?NS4eSOVT7A5XuVyh8FZPMqDtcXvOlG01g3+4X209B59YfGem1Ew7X52NEeYM?= =?us-ascii?Q?5nayVcffqvuBc5Xc4mqXTA08b/JJWnLv72TfvgveeA3yjtOcjwWPz4IHhSq/?= =?us-ascii?Q?Dt7vuZRfllUjubgILW8m2OBxnSxcA+cbARXgZ+siIx8Ks2lXLYfNXPi5S8jQ?= =?us-ascii?Q?5fI1du+mZ5CXlNkh5b9ukqSsduBlQEBE6453GZsTDXz6At55k5uzY8tKJ7g5?= =?us-ascii?Q?z+qBLDIwE6waHuWrYJb1cuJGevKtA7BGuDIZGcwBnWO9dEVbtsIue5lY418s?= =?us-ascii?Q?/sQr9fzEgliYhZb0MxqXqseSvaZ77kLzodw5V8gTnH2C6hbzQE5S2IVHm5Zh?= =?us-ascii?Q?NRjGo1XFQNQzVob5556/NPtW6vl9qoNHgCV6vo+ajMVLqGcDM6hh0pOV0HoP?= =?us-ascii?Q?7COBPRXiKv2rEntuoKIeo990uIpdfr2bR5Hb0AqU1Ar142QDPbweSf9A0aGc?= =?us-ascii?Q?WtocWPvjEtASNgRH5dqLtOVfR6ImVL7qpMpHzsjmzqOM7cDV+/zAekJAtoj9?= =?us-ascii?Q?O2LDyKSNacsOBNf+0EeLaUflvMuXss6Q3GFyCR20ieNUD3H6YbZUh/Z/UZiJ?= =?us-ascii?Q?7XdMwtMCulEfnaskNwYiykHWA5pK6ao9JzhvJdnh8HAB4tt7h45aUy0Iy6YE?= =?us-ascii?Q?jRlLZTEYyRiAUe/3yfmWhYTR6OAJF5pr6UyN3+FY8jzyMt39RrPMjEPeeF9a?= =?us-ascii?Q?1Agtq9rCxYhyhGkCobsNbKOAJJxAsx3SlU5JcpStuDbJC+dOF/01BueVDCjY?= =?us-ascii?Q?xBO8G4gvGUgKTbW+bLrG28JlLflxWA9cMFrIE79NBHO+nkbHGY6fThRUvaPf?= =?us-ascii?Q?jQ8BORqOBiKG8Gr9PTce3tFG8nP25skLAH/QURVqT47pmsPERuEEnd7cTIgj?= =?us-ascii?Q?0hPZS9/Y5i5K/Mqwa24Zo0UiNrgkjxF8TnKcwKOuVuYkgPUVcp8lJnLfiDLG?= =?us-ascii?Q?sAU3hFW5iilqExy6WCbGOSoB3KEaJIk5r1m6XMrJMEjGLuhELUsqp57IoHJ3?= =?us-ascii?Q?6VF6CAZnBKy52fwxS48TIMP3k9s2Zmxj7uznUuS0Re9mZHpWoXpGXYO/8tiZ?= =?us-ascii?Q?s+IPHGF2U=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR07MB622;5:VTOck9T0h876/eU9qgTCbRDq+rWjVBnn7K2QvgKtaLyhq4YJmQpLZC57OzJt4jdI9dQ8g/VGJx+TnRrEnT13lxGxlzOJx5l6VEv9LcI8oUmUCZ2II8rY6RmwPINj8m8SH4482gO18RHK8cWTglK9SQ==;24:f1DEoE9yBDgEK0NWsgV/Bt9LT8Q4PcsvP7ZyZ+lmgeM2MNNMinQ4uH+/obzeNQ3Rn8bjkmcK/tOXJLQ+n+TW7diS1xC0LjbDRQg9duddGvs= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2016 16:47:01.5845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR07MB622 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 10:08:44AM +0100, Arnd Bergmann wrote: > On Friday 08 January 2016 02:34:29 Yury Norov wrote: > > + > > +#include "../../../fs/compat_binfmt_elf.c" > > > > This is the wrong file, you have to include fs/binfmt_elf.c, otherwise > you pick up the same definitions that you have for the other one. > I chose compat as it's how it wokrs now. It redefines some types like user_long_t, and I think it's neccessary for ILP32, as for aarch32. > Alternatively, you can also change binfmt_elf32.c to include fs/binfmt_elf.c > and use fs/compat_binfmt_elf.c here if that makes the code nicer, you > just can use the compat file for both or things get ugly because of > the extra indirections. > > Arnd