From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763074AbcALQ7Z (ORCPT ); Tue, 12 Jan 2016 11:59:25 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:40859 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752999AbcALQ7X (ORCPT ); Tue, 12 Jan 2016 11:59:23 -0500 Date: Tue, 12 Jan 2016 08:59:19 -0800 From: Darren Hart To: Henrique de Moraes Holschuh Cc: Pavel Machek , Pali =?iso-8859-1?Q?Roh=E1r?= , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Message-ID: <20160112165919.GA1989@malice.jf.intel.com> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <20160104201231.GB5847@amd> <1452361154.673684.487414482.6CCEAE4B@webmail.messagingengine.com> <1452361601.676356.487415834.4652D305@webmail.messagingengine.com> <20160111190411.GE10643@malice.jf.intel.com> <1452540480.2848000.489039714.26068C20@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452540480.2848000.489039714.26068C20@webmail.messagingengine.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2016 at 05:28:00PM -0200, Henrique de Moraes Holschuh wrote: > > > Henrique, so are you taking back your Ack from 10 minutes prior? > > Hmm? No, the ACK stands. > > Pavel was talking about another feature altogether, apparently: older > thinkpads did not have "keyboard backlight" (as in light from below the > keys). They had a "ThinkLight", which is an overhead light that shines > down on the keyboard. > > The two features are not the same (and are handled differently by the > firmware, for whatever reason), although they do serve the same purpose. > I don't think a thinkpad will ever have both features at the same time, > so I have no idea why they changed the firmware interface. > > The patch adds support to the "keyboard backlight" feature, which was > previously NOT supported. > > > I've dropped this patch. Please let me know if I should pick it back up. > > Please pick it back up. > Gah, these two threads landed next to each other in my Inbox and I didn't pick up the split. Apologies. This is queued in testing (again). -- Darren Hart Intel Open Source Technology Center