From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421AbcALVx5 (ORCPT ); Tue, 12 Jan 2016 16:53:57 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54575 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbcALVxz (ORCPT ); Tue, 12 Jan 2016 16:53:55 -0500 Date: Tue, 12 Jan 2016 22:53:52 +0100 From: Pavel Machek To: "Andrew F. Davis" Cc: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, a.hajda@samsung.com Subject: Re: /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4? Message-ID: <20160112215352.GA5248@amd> References: <20160109230709.GA30551@amd> <5693BB75.70409@ti.com> <20160111214247.GA9735@amd> <56942344.9070609@ti.com> <56951A2C.9010602@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56951A2C.9010602@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > >>If not, tell me, and I can do it, but it will involve a lot of swaring... > > > >I'll give it a look over. > > OK, I'm still looking for a test setup, but this was definitely a problem, > could you give this a try?: Well, search no more. I tested it and seems to work ok. There's one more blank line in the source, so I had to apply patch by hand. Tested-by: Pavel Machek Acked-by: Pavel Machek Reported-by: Pavel Machek Cc: stable@vger.kernel.org ? :-). And... thanks! Pavel > diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c > index 880233c..4fec3cf 100644 > --- a/drivers/power/bq27xxx_battery.c > +++ b/drivers/power/bq27xxx_battery.c > @@ -470,8 +470,9 @@ static inline int bq27xxx_read(struct bq27xxx_device_info *di, int reg_index, > static int bq27xxx_battery_read_soc(struct bq27xxx_device_info *di) > { > int soc; > + bool single = di->chip == BQ27000 || di->chip == BQ27010; > - soc = bq27xxx_read(di, BQ27XXX_REG_SOC, false); > + soc = bq27xxx_read(di, BQ27XXX_REG_SOC, single); > if (soc < 0) > dev_dbg(di->dev, "error reading State-of-Charge\n"); -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html