From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753429AbcALV6J (ORCPT ); Tue, 12 Jan 2016 16:58:09 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54785 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbcALV6G (ORCPT ); Tue, 12 Jan 2016 16:58:06 -0500 Date: Tue, 12 Jan 2016 22:58:04 +0100 From: Pavel Machek To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Henrique de Moraes Holschuh , Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Message-ID: <20160112215804.GA12869@amd> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <20160111190411.GE10643@malice.jf.intel.com> <1452540480.2848000.489039714.26068C20@webmail.messagingengine.com> <201601112103.01145@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201601112103.01145@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Mon 2016-01-11 21:03:01, Pali Rohár wrote: > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > The two features are not the same (and are handled differently by the > > firmware, for whatever reason), although they do serve the same > > purpose. I don't think a thinkpad will ever have both features at > > the same time, so I have no idea why they changed the firmware > > interface. > > Maybe we should decide if ::kbd_backlight LED suffix could be used also > for other LED devices and not only for those which are physically under > the keyboard. Another problem is that N900 has _6_ backlight LEDs. Named lp5523::kb1..6. ... Which does means desktop software will probably not pick them up :-(. I guess we could have "/sys/class/kbd_light/brightness" that would control all of them with one write. Next question is.. apparently there are some keyboards that have per-key RGB backlight... but maybe we can just call that "weird enough" and ignore... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html