From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753946AbcAMCIK (ORCPT ); Tue, 12 Jan 2016 21:08:10 -0500 Received: from mail.kernel.org ([198.145.29.136]:41181 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbcAMCIG (ORCPT ); Tue, 12 Jan 2016 21:08:06 -0500 Date: Tue, 12 Jan 2016 20:07:59 -0600 From: Rob Herring To: Laxman Dewangan Cc: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com Subject: Re: [PATCH V2 1/6] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024 Message-ID: <20160113020759.GA16193@rob-hp-laptop> References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-2-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452590273-16421-2-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2016 at 02:47:48PM +0530, Laxman Dewangan wrote: > The MAXIM PMIC MAX77620 and MAX20024 are power management IC > which supports RTC, GPIO, DCDC/LDO regulators, interrupt, > watchdog etc. > > Add DT binding document for the different functionality of > this device. > > Signed-off-by: Laxman Dewangan > --- > Changes from V1: > - Added units in some of properties. > - Change the boolean property to tristate type and detail some of > properties. [...] > +Flexible power sequence configuration > +==================================== > +This sub-node configures the Flexible Power Sequnece(FPS) for power ON slot, > +power OFF slot and slot period of the device. Device has 3 FPS as FPS0, > +FPS1 and FPS2. The details of FPS configuration is provided through > +subnode "fps". The details of FPS0, FPS1, FPS2 are provided through the > +child node under this subnodes. The FPS number is provided via reg property. > + > +The property for fps child nodes as: > +Required properties: > + -reg: FPS number like 0, 1, 2 for FPS0, FPS1 and FPS2 respectively. > +Optinal properties: > + -maxim,active-fps-time-period: Active state FPS time period in > + microseconds. > + -maxim,suspend-fps-time-period: Suspend state FPS time period in > + microseconds. These property names need units, too. IOW, append with '-us', so something like "maxim,suspend-fps-time-us". Otherwise, looks fine to me.