From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755555AbcAMIQ3 (ORCPT ); Wed, 13 Jan 2016 03:16:29 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:34711 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752217AbcAMIQ1 (ORCPT ); Wed, 13 Jan 2016 03:16:27 -0500 Date: Wed, 13 Jan 2016 00:16:24 -0800 From: Dmitry Torokhov To: Laxman Dewangan Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, galak@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linus.walleij@linaro.org, bjorn.andersson@sonymobile.com Subject: Re: [PATCH V3 1/1] input: gpio-keys: add support for disable button from DT Message-ID: <20160113081624.GA21845@dtor-ws> References: <1452669980-16460-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452669980-16460-1-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 12:56:20PM +0530, Laxman Dewangan wrote: > Add support to disable the button from DT via status property > if given button is not supporting on given platforms. > > This will help to re-use the existing dtsi file with status > enable/disable across platforms. > > Signed-off-by: Laxman Dewangan Applied, thank you. > --- > Changes from V1: > - Converted print to dev_dbg. > Changes from V2: > - use of_get_available_child_count() and for_each_available_child_of_node() > > drivers/input/keyboard/gpio_keys.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c > index bef317f..ef6ca1c 100644 > --- a/drivers/input/keyboard/gpio_keys.c > +++ b/drivers/input/keyboard/gpio_keys.c > @@ -613,7 +613,7 @@ gpio_keys_get_devtree_pdata(struct device *dev) > if (!node) > return ERR_PTR(-ENODEV); > > - nbuttons = of_get_child_count(node); > + nbuttons = of_get_available_child_count(node); > if (nbuttons == 0) > return ERR_PTR(-ENODEV); > > @@ -629,7 +629,7 @@ gpio_keys_get_devtree_pdata(struct device *dev) > pdata->rep = !!of_get_property(node, "autorepeat", NULL); > > i = 0; > - for_each_child_of_node(node, pp) { > + for_each_available_child_of_node(node, pp) { > enum of_gpio_flags flags; > > button = &pdata->buttons[i++]; > -- > 2.1.4 > -- Dmitry