From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755796AbcAMISV (ORCPT ); Wed, 13 Jan 2016 03:18:21 -0500 Received: from down.free-electrons.com ([37.187.137.238]:56367 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755763AbcAMIST (ORCPT ); Wed, 13 Jan 2016 03:18:19 -0500 Date: Wed, 13 Jan 2016 09:18:17 +0100 From: Boris Brezillon To: Milo Kim Cc: , Jason Cooper , Marc Zyngier , Ludovic Desroches , Nicholas Ferre , Subject: Re: [PATCH 4/4] irqchip: atmel-aic: Remove duplicate bit operation Message-ID: <20160113091817.3efc706a@bbrezillon> In-Reply-To: <1452669592-3401-4-git-send-email-milo.kim@ti.com> References: <1452669592-3401-1-git-send-email-milo.kim@ti.com> <1452669592-3401-4-git-send-email-milo.kim@ti.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jan 2016 16:19:52 +0900 Milo Kim wrote: > AIC5 priority value is updated twice - > in aic_common_set_priority() and when updating AT91_AIC5_SMR. > Variable, 'smr' has updated priority value (intspec[2]) in the first step, > so no need to update it again in the second step. > > Signed-off-by: Milo Kim > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: Marc Zyngier > Cc: Boris Brezillon > Cc: Ludovic Desroches > Cc: Nicholas Ferre > Cc: linux-kernel@vger.kernel.org Acked-by: Boris Brezillon Thanks, Boris > --- > drivers/irqchip/irq-atmel-aic5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c > index f36f426..4f0d068 100644 > --- a/drivers/irqchip/irq-atmel-aic5.c > +++ b/drivers/irqchip/irq-atmel-aic5.c > @@ -273,7 +273,7 @@ static int aic5_irq_domain_xlate(struct irq_domain *d, > irq_reg_writel(bgc, *out_hwirq, AT91_AIC5_SSR); > smr = irq_reg_readl(bgc, AT91_AIC5_SMR); > aic_common_set_priority(intspec[2], &smr); > - irq_reg_writel(bgc, intspec[2] | smr, AT91_AIC5_SMR); > + irq_reg_writel(bgc, smr, AT91_AIC5_SMR); > irq_gc_unlock(bgc); > > return ret; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com