From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933622AbcAMKcu (ORCPT ); Wed, 13 Jan 2016 05:32:50 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37018 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933170AbcAMKcp (ORCPT ); Wed, 13 Jan 2016 05:32:45 -0500 Date: Wed, 13 Jan 2016 11:32:41 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Sebastian Reichel Cc: Pavel Machek , "Andrew F. Davis" , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, a.hajda@samsung.com Subject: Re: /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4? Message-ID: <20160113103241.GH11560@pali> References: <20160109230709.GA30551@amd> <5693BB75.70409@ti.com> <20160111214247.GA9735@amd> <56942344.9070609@ti.com> <56951A2C.9010602@ti.com> <20160112215352.GA5248@amd> <20160113084424.GC11560@pali> <20160113102613.GA28729@earth> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160113102613.GA28729@earth> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 13 January 2016 11:26:13 Sebastian Reichel wrote: > On Wed, Jan 13, 2016 at 09:44:24AM +0100, Pali Rohár wrote: > > On Tuesday 12 January 2016 22:53:52 Pavel Machek wrote: > > > Hi! > > > > > > > >>If not, tell me, and I can do it, but it will involve a lot of swaring... > > > > > > > > > >I'll give it a look over. > > > > > > > > OK, I'm still looking for a test setup, but this was definitely a problem, > > > > could you give this a try?: > > > > > > Well, search no more. I tested it and seems to work ok. There's one > > > more blank line in the source, so I had to apply patch by hand. > > > > > > Tested-by: Pavel Machek > > > Acked-by: Pavel Machek > > > Reported-by: Pavel Machek > > > Cc: stable@vger.kernel.org > > > > > > ? :-). > > > > > > And... thanks! > > > Pavel > > > > There are more pending fixes for bq27xxx... Maybe your is duplicate? > > No, it's not a duplicate. > > > http://thread.gmane.org/gmane.linux.power-management.general/70090 > > http://thread.gmane.org/gmane.linux.power-management.general/69716/focus=69714 > > http://thread.gmane.org/gmane.linux.power-management.general/69716/focus=2110580 Hm... It looks like Pavel's patch is subset of this 3rd patch as it fix function bq27xxx_battery_read_soc() > > Sebastian, please take them and ideally send to stable@ for backporting. > > There is no need to send them to stable@, if they are properly > tagged with a 'Fixes: ("title")' tag, so please always > include it in your commit messages, if possible :) I have not sent those patches, but OK. In that email thread you can find sha1 commit id which broke it. -- Pali Rohár pali.rohar@gmail.com