From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] perf tools: Do not show trace command if it's not compiled in
Date: Wed, 13 Jan 2016 11:42:55 +0100 [thread overview]
Message-ID: <20160113104254.GA9854@gmail.com> (raw)
In-Reply-To: <20160112142956.GU18367@kernel.org>
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Tue, Jan 12, 2016 at 12:23:41PM +0100, Ingo Molnar escreveu:
> >
> > * Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > > The trace command still appears in help message when you
> > > run simple 'perf' command.
> > >
> > > It's because the generate-cmdlist.sh does not care about the
> > > HAVE_LIBAUDIT_SUPPORT dependency of trace command and puts
> > > it into generated common_cmds array.
> > >
> > > Wrapping trace command under HAVE_LIBAUDIT_SUPPORT dependency,
> > > which will exclude it from common_cmds array if HAVE_LIBAUDIT_SUPPORT
> > > is not set.
> >
> > Btw., would it make sense to still list them, but denote them as '[NOT BUILT IN]':
>
> Yeah, just like we have:
>
> $ make NO_DWARF=1 O=/tmp/build/perf -C tools/perf/ install
> make: Entering directory '/home/git/linux/tools/perf'
> BUILD: Doing 'make -j4' parallel build
> config/Makefile:328: DWARF support is off, BPF prologue is disabled
> SUBDIR Documentation
> ASCIIDOC /tmp/build/perf/perf-diff.xml
> CC /tmp/build/perf/util/abspath.o
> <SNIP>
>
> $ perf record -h vm build
>
> Usage: perf record [<options>] [<command>]
> or: perf record [<options>] -- <command> [<options>]
>
> -B, --no-buildid do not collect buildids in perf.data
> -N, --no-buildid-cache do not update the buildid cache
> --vmlinux <file> vmlinux pathname
> (not built-in because NO_DWARF=1)
Very nice!
Thanks,
Ingo
next prev parent reply other threads:[~2016-01-13 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 16:31 [PATCH] perf tools: Do not show trace command if it's not compiled in Jiri Olsa
2016-01-12 11:23 ` Ingo Molnar
2016-01-12 14:29 ` Arnaldo Carvalho de Melo
2016-01-13 10:42 ` Ingo Molnar [this message]
2016-01-25 18:22 ` 'perf stat --repeat N' oddity/regression Ingo Molnar
2016-01-25 18:35 ` Ingo Molnar
2016-01-25 19:43 ` Arnaldo Carvalho de Melo
2016-01-25 19:48 ` Arnaldo Carvalho de Melo
2016-01-26 8:08 ` Ingo Molnar
2016-01-26 14:18 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113104254.GA9854@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).