From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933072AbcAMKnF (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jan 2016 05:43:05 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:33005 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932840AbcAMKm7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jan 2016 05:42:59 -0500
Date: Wed, 13 Jan 2016 11:42:55 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] perf tools: Do not show trace command if it's not
 compiled in
Message-ID: <20160113104254.GA9854@gmail.com>
References: <1450629119-508-1-git-send-email-jolsa@kernel.org>
 <20160112112341.GB26496@gmail.com>
 <20160112142956.GU18367@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160112142956.GU18367@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Tue, Jan 12, 2016 at 12:23:41PM +0100, Ingo Molnar escreveu:
> > 
> > * Jiri Olsa <jolsa@kernel.org> wrote:
> > 
> > > The trace command still appears in help message when you
> > > run simple 'perf' command.
> > > 
> > > It's because the generate-cmdlist.sh does not care about the
> > > HAVE_LIBAUDIT_SUPPORT dependency of trace command and puts
> > > it into generated common_cmds array.
> > > 
> > > Wrapping trace command under HAVE_LIBAUDIT_SUPPORT dependency,
> > > which will exclude it from common_cmds array if HAVE_LIBAUDIT_SUPPORT
> > > is not set.
> > 
> > Btw., would it make sense to still list them, but denote them as '[NOT BUILT IN]':
> 
> Yeah, just like we have:
> 
>   $ make NO_DWARF=1 O=/tmp/build/perf -C tools/perf/ install
>   make: Entering directory '/home/git/linux/tools/perf'
>     BUILD:   Doing 'make -j4' parallel build
>   config/Makefile:328: DWARF support is off, BPF prologue is disabled
>     SUBDIR   Documentation
>     ASCIIDOC /tmp/build/perf/perf-diff.xml
>     CC       /tmp/build/perf/util/abspath.o
>   <SNIP>
> 
>   $ perf record -h vm build
> 
>    Usage: perf record [<options>] [<command>]
>       or: perf record [<options>] -- <command> [<options>]
> 
>       -B, --no-buildid        do not collect buildids in perf.data
>       -N, --no-buildid-cache  do not update the buildid cache
>           --vmlinux <file>    vmlinux pathname
>                               (not built-in because NO_DWARF=1)

Very nice!

Thanks,

	Ingo