From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757085AbcAMN1q (ORCPT ); Wed, 13 Jan 2016 08:27:46 -0500 Received: from www.linutronix.de ([62.245.132.108]:49565 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756908AbcAMN1m (ORCPT ); Wed, 13 Jan 2016 08:27:42 -0500 Date: Wed, 13 Jan 2016 14:27:39 +0100 From: Sebastian Andrzej Siewior To: kernel test robot Cc: lkp@01.org, LKML , Steven Rostedt Subject: Re: [lkp] [ptrace] 63a745aa6a: inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage. Message-ID: <20160113132739.GC29964@linutronix.de> References: <87y4cbquqe.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87y4cbquqe.fsf@yhuang-dev.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Subject: [PATCH RT] ptrace: don't open IRQs in ptrace_freeze_traced() too early In the non-RT case the spin_lock_irq() here disables interrupts as well as raw_spin_lock_irq(). So in the unlock case the interrupts are enabled too early. Reported-by: kernel test robot Cc: stable-rt@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior --- kernel/ptrace.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/ptrace.c b/kernel/ptrace.c index d1d158005ad0..2856b433d9d6 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c @@ -129,12 +129,14 @@ static bool ptrace_freeze_traced(struct task_struct *task) spin_lock_irq(&task->sighand->siglock); if (task_is_traced(task) && !__fatal_signal_pending(task)) { - raw_spin_lock_irq(&task->pi_lock); + unsigned long flags; + + raw_spin_lock_irqsave(&task->pi_lock, flags); if (task->state & __TASK_TRACED) task->state = __TASK_TRACED; else task->saved_state = __TASK_TRACED; - raw_spin_unlock_irq(&task->pi_lock); + raw_spin_unlock_irqrestore(&task->pi_lock, flags); ret = true; } spin_unlock_irq(&task->sighand->siglock); -- 2.7.0.rc3