From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753526AbcAMQVa (ORCPT ); Wed, 13 Jan 2016 11:21:30 -0500 Received: from mail-bn1bon0071.outbound.protection.outlook.com ([157.56.111.71]:9978 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752688AbcAMQV2 (ORCPT ); Wed, 13 Jan 2016 11:21:28 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Wed, 13 Jan 2016 19:21:11 +0300 From: Yury Norov To: Arnd Bergmann CC: , , , , , , , , , , , , , , , , Andrew Pinski , Andrew Pinski Subject: Re: [PATCH v6 14/21] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Message-ID: <20160113162111.GA31636@yury-N73SV> References: <1452209679-19445-1-git-send-email-ynorov@caviumnetworks.com> <1452209679-19445-15-git-send-email-ynorov@caviumnetworks.com> <8354919.jOyEk0znB5@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8354919.jOyEk0znB5@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: DB4PR07CA027.eurprd07.prod.outlook.com (10.242.229.37) To BY2PR07MB614.namprd07.prod.outlook.com (10.141.222.146) X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB614;2:q4vfb6Xs+SQMFciH1M4Lz5qFbLLNpHMFhQh8QASNUHeAi9/o+gzk7E5e+wrr0atA1rRcgb80TKW5CpJnHIh2ayP/6UORRRa+2JXvECWmLIdaOeo/sPkLviZrB8Nv86Ob2MbhUzCyfGCyaiVBrzmnqw==;3:lAXX/6hQbNt+FpFeovvwttUQsBb7H+0I68Zuk4KtFuGLdiveQf56CJk0N1pgGmu6QeA+CceJMz6r/tMdomUp7OKC9/MhkfdeKGgq6KeEkHMGkB3fuXlEgamx7yz5VmfH;25:M73ut0yQJwG0uEdo+9qZhnj/2gdqR3nIEuOBaKwmidiRgF2oSOPDKL2sdvJ9m+eEuy3KxTIdDG2Gw9bPtXUNxS5hEs3cMmFXqa9/RUGP5h7+uXDBQfZ6q+Za46D1ypapWM4sHuhYO2CT62qTPbfE3uLRyhVSJ5g89R6Awpav4pgWF7VQR75CKWt3q/PP/q0pbIuvugyeVdmWVDjQDRIiqWUqkIOAMLvGnZonH40Z7BOcJ7qgEiDlW3Qf8j87lR0n X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB614; X-MS-Office365-Filtering-Correlation-Id: 318edcfe-2515-412e-f921-08d31c359599 X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB614;20:uJtxVwRurKKwI/SbkWMJE1E6bbePWCswKY4fFzHJc3xYe9iriT96h864A5aOkewRjieAJ24ILD4/FnCrJhxEErCQc+Z+M1fyPQHsthZ5HTacmiYy1N9PwDQdFgozfrf3LVxQY0OrmkUt3r4AHQnpxpSU1GAjJqLXcml5kInedvJ72F+/9CYnfgg58d0l8SEGrKoksZsaUo6+zQqu29tyCsyz79iF5xU234TXzQk7LSy7LvFwe2YYI4Pk/D8YTcbpTcfWVyu36oZZtvxOUdQYAGkYbUSlh7XXmxexQvqUWeJElLs0NJrf2o7HYjKAA3aGZ5YVNNWYJDC6jWGv28ZIT2YrFq/sZmVoqZL1mAXwJ6jdZ2+UV+kAeVTpelmZChXJUbpsENe8Q6B210wYc+uDfTyuYOGUtqei5LYJtamqaKaNqbDVpPrgQ9ANd/Gsf2y+jpf+I3Dx70Zqg7eRA5t41zEajklKe3UDun9/YQLa/Wg3GdzHB27I+hEcj7OY+/7rB0RoRiwb7e+wfDV3Tk3ICOSRSdRl5GhEZD/j3YqobnX29kA41CAlxVCTKQ8j6vGMFPyU2xIfkAfxjQXYBvAGnlivZfjzcseUTC4zjRyrWlM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046);SRVR:BY2PR07MB614;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB614; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB614;4:TshQPqRCrelg8Dn3EeBvM+Fiwruk15gLFHd4bnZEg3ToHCiLJIbC51N4BAZIhrlO+8HhsjqnwlN3XUUyVnEIl2F32xKtRpYu0+xAV8Hb+TzM63Z5m4yYqBajNzGEKot9FZRLVhcHm+i5zqOFvREjB+jXuT8KihVFeOrJK0ZYTK8JrlXudFzr0DHNuThWIXCxvzGS7BFbOMNHZIlqwvaPevPFqqaIfbdKNIal2GYE5NiDtC4kPe6Psy1aH7Oq7MFe3DcDf/xEvZrWg+LaMAVmdwMxQ3FcL6B8ciOrXYPhVf7wKWNve/F79UH5Vnr/kehm0Bk7r/wZqhSy5kIwEUvdPJqYkayGaZ8gjB+GkhBrserFl6GcGBT5dgr4WStXCcNr X-Forefront-PRVS: 08200063E9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(24454002)(199003)(189002)(4001350100001)(107886002)(81156007)(5001960100002)(4001430100002)(110136002)(2950100001)(77096005)(97736004)(189998001)(47776003)(87976001)(4326007)(54356999)(5004730100002)(50986999)(5008740100001)(83506001)(122386002)(66066001)(76176999)(92566002)(40100003)(3846002)(23726003)(1076002)(6116002)(1096002)(586003)(101416001)(33656002)(46406003)(97756001)(105586002)(33716001)(50466002)(2906002)(42186005)(106356001)(76506005);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR07MB614;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR07MB614;23:aSfUp4Z7sIc7NPlaUTyssZD7zDU4O3ffVS/u67igtr?= =?us-ascii?Q?TpUaARpXjwJLubX5WcFD4lmIWMHxItE5Vlh9gMzvAoBJimLesQY/brkkTRls?= =?us-ascii?Q?rkPxNyPa8n06XjH4uuT9ytW9ybsFn0lZ4cLhTJJaqk7EFXYTpSvxnLo9invS?= =?us-ascii?Q?Zdp/1YMwzt2JgSzrANnmKahHqwDZcP7Hglww5KqC2d0LNpwzJzzPflifdLI5?= =?us-ascii?Q?xBfpAzBhiX1Rx8sLvbV6BgEMOi3zicY2DIK+sNOOQjgnEvM+Z1H+CVZIlLo9?= =?us-ascii?Q?k8doo3LpCQ0W1UYd46tkc5bCeiVcBrCc7P8qkjtldI4IW5jHTomjLCznb3zV?= =?us-ascii?Q?jNMlVeAsJic25yacCLtNIxAX7If/7uKoB82YOvhhnWC/dWj4c0T0UGvpJg7B?= =?us-ascii?Q?Pk1VbWe26jzV9egT9kx/+gKkN7Uk57Q0SsPJ7lbYYmoyPFi55uL7KSP1IkMQ?= =?us-ascii?Q?cUMVED5PvyDsuBAb4TzNDOFiSWPTN3RD5R+9TIMJvysVZ5QSZZ7PQQVNTcnb?= =?us-ascii?Q?gabRv1tAEYoFCRPfDiGotUeS5tE+5swOGyKGB8T8Tl+Deuu+9fJNqGbnI1xP?= =?us-ascii?Q?Vp6+pJj3nKQebVsguqsCH05YTReFQ+SHTe8C2wwzKpVbFknlh1RcPES5j4m9?= =?us-ascii?Q?bgx77TiF748optsgzH1TOvReL4GYB5KqaGMNXAZSiAB4jmBCKcYHO69vpJZt?= =?us-ascii?Q?vnyVPGi0Ln1n1RoNUk994tKj2YuRJklF4Y6oOiCjODGftHt5z+ubqTDdF5rA?= =?us-ascii?Q?XATQ9bW86Ic22e28R21jJwsCW6mXAi1QRBogmojtq/9sBTy1JGHfoSXZkAfp?= =?us-ascii?Q?29xH7xivnZ9asiNvdo9ua+AktyVaq8neoZuS+FwuDU8KeglsD+Zy0H2jK5m1?= =?us-ascii?Q?mSs57ra5KJCwCf2lq86USvwRKLXAOzxb7zySq6wY0icyFPRRjPpidRAaRjyR?= =?us-ascii?Q?YZ0BXbIZ5uXvZaNgkYRzhCuP2CNIcZxXM3n3OhVyNNipfN9l6hkCGjmm10kQ?= =?us-ascii?Q?HnyUYI7GG4j26WYf589VpDHIlrKAdQZKrbPRcPF2rz68bjv+teg52loKQA0o?= =?us-ascii?Q?PGFUIl3DQ6ehRfu8kg/ZlYZVpFGSqeYcKgOtmEija2lAMAYeO+Ev+75tnHuB?= =?us-ascii?Q?U+lo7gSAUPEYqiLIeMMs1EpjFOo1o56vYqAKHwJ0q8qCTXVlU5uw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB614;5:meKiaWjf7RPUgOhFO43pxgQc87XwpJfFPFlVsKt+rzdh5sTTXYRDhvD0bU2p6Q4+AHLZzr8OM3F+b9UnC37hTjdTJpYAUgoFzcG8sl9A8o9HQCwfwuIx6qkVjLFvqV8Ij8eNjNKeRj7mcKdy0fZzMw==;24:erwaUJMqERtjImtD+g+HiWJGkiXYjl92kZYf6EHM1RtoiUqA2bphythxYqE3uJ4w/TfbmEsqaR2KpLCSpseRegXYa7rWdu9fkFMJT85LTmY= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2016 16:21:25.3424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB614 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 10:21:06AM +0100, Arnd Bergmann wrote: > On Friday 08 January 2016 02:34:32 Yury Norov wrote: > > > @@ -688,6 +692,12 @@ ni_sys: > > b ret_fast_syscall > > ENDPROC(el0_svc) > > > > +#ifdef CONFIG_ARM64_ILP32 > > +el0_ilp32_svc: > > + adrp stbl, sys_call_ilp32_table // load syscall table pointer > > + b el0_svc_naked > > +#endif > > Don't we still need some code that clears the top halves of the 32-bit > arguments? That thread has taken so many turns now that I'm confused > about what we actually need, but I thought we had concluded that your > current approach has at some some problems. > > > +#include > > + > > +#undef __SYSCALL > > +#undef __SC_COMP > > +#undef __SC_3264 > > +#undef __SC_COMP_3264 > > The four #undef are not needed, right? > > Arnd No, removing any of them follows compilation problems.