From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754118AbcAMQg1 (ORCPT ); Wed, 13 Jan 2016 11:36:27 -0500 Received: from mail.skyhub.de ([78.46.96.112]:33253 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbcAMQgZ (ORCPT ); Wed, 13 Jan 2016 11:36:25 -0500 Date: Wed, 13 Jan 2016 17:36:10 +0100 From: Borislav Petkov To: Jacob Pan Cc: Thomas Gleixner , LKML , Linux PM , Rafael Wysocki , "H. Peter Anvin" , Ingo Molnar , X86 Kernel , Srinivas Pandruvada , Peter Zijlstra Subject: Re: [PATCH v2 2/2] powercap/rapl: reduce ipi calls Message-ID: <20160113163610.GH12897@pd.tnic> References: <1452647483-14244-1-git-send-email-jacob.jun.pan@linux.intel.com> <1452647483-14244-3-git-send-email-jacob.jun.pan@linux.intel.com> <20160113082113.3314fa92@icelake> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160113082113.3314fa92@icelake> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 08:21:13AM -0800, Jacob Pan wrote: > Thanks for bring this out. I didn't mean to ignore. I thought my point > was stated in the commit message there was no point of going back and > forth. Read-Modify-Write is quite common, not just for RAPL could be > used by future code. Sorry if I wasn't clear. But it also shows that it doesn't suffice for all your needs. So why add it? You can much better define your own functions which do all the MSR handling you require and call them with smp_call_function_*. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.