From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755165AbcAMQtO (ORCPT ); Wed, 13 Jan 2016 11:49:14 -0500 Received: from mail.us.es ([193.147.175.20]:55660 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754822AbcAMQtK (ORCPT ); Wed, 13 Jan 2016 11:49:10 -0500 Date: Wed, 13 Jan 2016 17:49:03 +0100 From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Westphal Subject: Re: [PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter __maybe_unused Message-ID: <20160113164903.GA4121@salvia> References: <6200241.eeH6DHXzHj@wuerfel> <20160113155424.GA1581@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160113155424.GA1581@salvia> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 04:54:24PM +0100, Pablo Neira Ayuso wrote: > On Wed, Jan 13, 2016 at 02:58:11PM +0100, Arnd Bergmann wrote: > > The newly added nft_ct_get_eval_counter() function is only used when > > CONFIG_NF_CONNTRACK_LABELS is set, otherwise gcc warns about the > > unused definition: > > > > netfilter/nft_ct.c:34:12: warning: 'nft_ct_get_eval_counter' defined but not used [-Wunused-function] > > static u64 nft_ct_get_eval_counter(const struct nf_conn_counter *c, > > > > This marks the function __maybe_unused to shut up the warning. > > It seems that function doesn't below to CONFIG_NF_CONNTRACK_LABELS as > it is part of the new counter support. Will be sending an alternate > patch instead. Just for the record, I submitted this fix: http://patchwork.ozlabs.org/patch/567063/