From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Kishon Vijay Abraham I" <kishon@ti.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
sre@debian.org, sre@ring0.de,
"kernel list" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com
Subject: Re: Nokia N900: u-SD card in v4.2+
Date: Wed, 13 Jan 2016 11:20:08 -0800 [thread overview]
Message-ID: <20160113192007.GK12777@atomide.com> (raw)
In-Reply-To: <20160113191240.GA10717@amd>
* Pavel Machek <pavel@ucw.cz> [160113 11:13]:
> On Mon 2016-01-11 14:10:23, Kishon Vijay Abraham I wrote:
> >
> > 'select' is generally not recommended since it selects a config without
> > caring for the dependency. With adding 'depends on', MMC won't be enabled and
> > will end up in the same problem.
>
> Well... it really should "depend on". Not ideal, but you'll likely
> realize what went on.
>
> Silently compiling known-bad kernel is ... well.. bad.
Force selects will lead into build errors sooner or later.
> > Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
> > should be enabled for MMCs to work.
> > commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
> > Author: Tony Lindgren <tony@atomide.com>
> > Date: Mon Oct 12 16:19:54 2015 -0700
> >
> > Documentation: ARM: List new omap MMC requirements
> >
> > Maybe we should also make the error message a little more verbose to tell the
> > user that CONFIG_REGULATOR_PBIAS be selected?
>
> That would help.
>
> As would #error if we recognize broken config.
Can't we just add a check to the omap_hsmmc.c? In cases where
MMC1 has the PBIAS regulator configured but not available, print
an error about missing CONFIG_REGULATOR_PBIAS error and return
-EPROBE_DEFER?
Regards,
Tony
prev parent reply other threads:[~2016-01-13 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 20:46 Nokia N900: u-SD card in v4.2+ Pavel Machek
2016-01-07 5:40 ` Kishon Vijay Abraham I
2016-01-07 11:34 ` Pavel Machek
2016-01-09 22:44 ` Pali Rohár
2016-01-11 8:40 ` Kishon Vijay Abraham I
2016-01-13 19:12 ` Pavel Machek
2016-01-13 19:20 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113192007.GK12777@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@debian.org \
--cc=sre@ring0.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).