From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757852AbcAMTUR (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jan 2016 14:20:17 -0500
Received: from muru.com ([72.249.23.125]:55167 "EHLO muru.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755975AbcAMTUN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jan 2016 14:20:13 -0500
Date: Wed, 13 Jan 2016 11:20:08 -0800
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
        Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>, sre@debian.org,
        sre@ring0.de, kernel list <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-omap@vger.kernel.org, khilman@kernel.org, aaro.koskinen@iki.fi,
        ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com
Subject: Re: Nokia N900: u-SD card in v4.2+
Message-ID: <20160113192007.GK12777@atomide.com>
References: <20160106204627.GA21477@amd>
 <568DFA4B.7030308@ti.com>
 <20160107113408.GA26618@amd>
 <201601092344.44641@pali>
 <56936A77.9070803@ti.com>
 <20160113191240.GA10717@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160113191240.GA10717@amd>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Pavel Machek <pavel@ucw.cz> [160113 11:13]:
> On Mon 2016-01-11 14:10:23, Kishon Vijay Abraham I wrote:
> > 
> > 'select' is generally not recommended since it selects a config without
> > caring for the dependency. With adding 'depends on', MMC won't be enabled and
> > will end up in the same problem.
> 
> Well... it really should "depend on". Not ideal, but you'll likely
> realize what went on.
> 
> Silently compiling known-bad kernel is ... well.. bad.

Force selects will lead into build errors sooner or later.

> > Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
> > should be enabled for MMCs to work.
> > commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
> > Author: Tony Lindgren <tony@atomide.com>
> > Date:   Mon Oct 12 16:19:54 2015 -0700
> > 
> >     Documentation: ARM: List new omap MMC requirements
> > 
> > Maybe we should also make the error message a little more verbose to tell the
> > user that CONFIG_REGULATOR_PBIAS be selected?
> 
> That would help.
> 
> As would #error if we recognize broken config.

Can't we just add a check to the omap_hsmmc.c? In cases where
MMC1 has the PBIAS regulator configured but not available, print
an error about missing CONFIG_REGULATOR_PBIAS error and return
-EPROBE_DEFER?

Regards,

Tony