From: Dan Carpenter <dan.carpenter@oracle.com>
To: Felipe Ferreri Tonello <eu@felipetonello.com>
Cc: Michal Nazarewicz <mina86@mina86.com>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Robert Baldyga <r.baldyga@samsung.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Pawel Szewczyk <p.szewczyk@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/2] usb: gadget: f_midi: use flexible array member for gmidi_in_port elements
Date: Wed, 13 Jan 2016 23:41:37 +0300 [thread overview]
Message-ID: <20160113204137.GC4399@mwanda> (raw)
In-Reply-To: <569696CE.1000707@felipetonello.com>
On Wed, Jan 13, 2016 at 06:26:22PM +0000, Felipe Ferreri Tonello wrote:
> > @@ -1115,26 +1112,16 @@ static struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
> > }
> >
> > /* allocate and initialize one new instance */
> > - midi = kzalloc(sizeof(*midi), GFP_KERNEL);
> > + midi = kzalloc(
> > + sizeof(*midi) + opts->in_ports * sizeof(*midi->in_ports_array),
> > + GFP_KERNEL);
>
> Is there a garantee that the compiler will always use in_ports_array at
> the end of the allocated block?
>
Yes. It's fine. Zero size arrays at the end of a struct are normal.
regards,
dan carpenter
next prev parent reply other threads:[~2016-01-13 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 3:47 [PATCHv2 1/2] usb: gadget: f_midi: use flexible array member for gmidi_in_port elements Michal Nazarewicz
2016-01-09 3:47 ` [PATCH 2/2] usb: gadget: f_midi: missing unlock on error path Michal Nazarewicz
2016-01-13 18:29 ` Felipe Ferreri Tonello
2016-01-13 18:26 ` [PATCHv2 1/2] usb: gadget: f_midi: use flexible array member for gmidi_in_port elements Felipe Ferreri Tonello
2016-01-13 20:41 ` Dan Carpenter [this message]
2016-01-18 16:02 ` Michal Nazarewicz
2016-01-19 9:46 ` Felipe Ferreri Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113204137.GC4399@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=eu@felipetonello.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=p.szewczyk@samsung.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox