From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbcAMXCx (ORCPT ); Wed, 13 Jan 2016 18:02:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:39984 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424AbcAMXCa (ORCPT ); Wed, 13 Jan 2016 18:02:30 -0500 Date: Wed, 13 Jan 2016 15:02:28 -0800 From: Mark Fasheh To: Gang He Cc: rgoldwyn@suse.de, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, akpm@linux-foundation.org Subject: Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check Message-ID: <20160113230228.GJ819@wotan.suse.de> Reply-To: Mark Fasheh References: <1451027779-6849-1-git-send-email-ghe@suse.com> <1451027779-6849-2-git-send-email-ghe@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451027779-6849-2-git-send-email-ghe@suse.com> Organization: SUSE Labs User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 25, 2015 at 03:16:16PM +0800, Gang He wrote: > Export ocfs2_kset object from ocfs2_stackglue kernel module, > then online file check code will create the related sysfiles > under ocfs2_kset object. > > Signed-off-by: Gang He Reviewed-by: Mark Fasheh This was easy to review, though you might consider adding a note that we're exporting this because it's built in ocfs2_stackglue.ko. --Mark > --- > fs/ocfs2/stackglue.c | 3 ++- > fs/ocfs2/stackglue.h | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c > index 5d965e8..13219ed 100644 > --- a/fs/ocfs2/stackglue.c > +++ b/fs/ocfs2/stackglue.c > @@ -629,7 +629,8 @@ static struct attribute_group ocfs2_attr_group = { > .attrs = ocfs2_attrs, > }; > > -static struct kset *ocfs2_kset; > +struct kset *ocfs2_kset; > +EXPORT_SYMBOL_GPL(ocfs2_kset); > > static void ocfs2_sysfs_exit(void) > { > diff --git a/fs/ocfs2/stackglue.h b/fs/ocfs2/stackglue.h > index 66334a3..f2dce10 100644 > --- a/fs/ocfs2/stackglue.h > +++ b/fs/ocfs2/stackglue.h > @@ -298,4 +298,6 @@ void ocfs2_stack_glue_set_max_proto_version(struct ocfs2_protocol_version *max_p > int ocfs2_stack_glue_register(struct ocfs2_stack_plugin *plugin); > void ocfs2_stack_glue_unregister(struct ocfs2_stack_plugin *plugin); > > +extern struct kset *ocfs2_kset; > + > #endif /* STACKGLUE_H */ > -- > 2.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Mark Fasheh