From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
lizefan@huawei.com, Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 3/9] perf build: Test correct path of perf in build-test
Date: Thu, 14 Jan 2016 11:04:45 +0100 [thread overview]
Message-ID: <20160114100445.GD31454@krava.brq.redhat.com> (raw)
In-Reply-To: <1452687442-6186-4-git-send-email-wangnan0@huawei.com>
On Wed, Jan 13, 2016 at 12:17:16PM +0000, Wang Nan wrote:
SNIP
> ( eval $$cmd ) >> $@ 2>&1 && \
> rm -f $@
>
> +KBUILD_OUTPUT_DIR := ../..
> +ifneq ($(O),)
> + KBUILD_OUTPUT_DIR := $(O)
> +endif
> +
> make_kernelsrc:
> @echo "- make -C <kernelsrc> $(PARALLEL_OPT) tools/perf"
> $(call clean); \
> (make -C ../.. $(PARALLEL_OPT) tools/perf) > $@ 2>&1 && \
> - test -x perf && rm -f $@ || (cat $@ ; false)
> + test -x $(KBUILD_OUTPUT_DIR)/tools/perf && rm -f $@ || (cat $@ ; false)
do you miss one extra /perf in here? like it should be
test -x $(KBUILD_OUTPUT_DIR)/tools/perf/perf
>
> make_kernelsrc_tools:
> @echo "- make -C <kernelsrc>/tools $(PARALLEL_OPT) perf"
> $(call clean); \
> (make -C ../../tools $(PARALLEL_OPT) perf) > $@ 2>&1 && \
> - test -x perf && rm -f $@ || (cat $@ ; false)
> + test -x $(KBUILD_OUTPUT_DIR)/tools/perf && rm -f $@ || (cat $@ ; false)
ditto
thanks,
jirka
>
> all: $(run) $(run_O) tarpkg make_kernelsrc make_kernelsrc_tools
> @echo OK
> --
> 1.8.3.4
>
next prev parent reply other threads:[~2016-01-14 10:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 12:17 [PATCH 0/9] perf build: Make build-test faster Wang Nan
2016-01-13 12:17 ` [PATCH 1/9] perf build: Set parallel making options build-test Wang Nan
2016-01-19 13:34 ` [tip:perf/urgent] " tip-bot for Wang Nan
2016-01-13 12:17 ` [PATCH 2/9] perf build: Pass O option to Makefile.perf in build-test Wang Nan
2016-01-14 9:32 ` Jiri Olsa
2016-01-14 9:56 ` Wangnan (F)
2016-01-14 14:28 ` Arnaldo Carvalho de Melo
2016-01-14 14:37 ` Jiri Olsa
2016-01-14 14:42 ` Arnaldo Carvalho de Melo
2016-01-14 15:20 ` pi3orama
2016-01-13 12:17 ` [PATCH 3/9] perf build: Test correct path of perf " Wang Nan
2016-01-14 9:56 ` Jiri Olsa
2016-01-14 9:57 ` Jiri Olsa
2016-01-14 9:59 ` Wangnan (F)
2016-01-14 10:03 ` Jiri Olsa
2016-01-14 10:04 ` Jiri Olsa [this message]
2016-01-14 10:14 ` Wangnan (F)
2016-01-13 12:17 ` [PATCH 4/9] perf build: Pass O option to kernel makefile " Wang Nan
2016-01-13 12:17 ` [PATCH 5/9] perf build: Add feature-dump target Wang Nan
2016-01-13 12:17 ` [PATCH 6/9] perf build: Introduce FEATURES_DUMP make variable Wang Nan
2016-01-13 12:17 ` [PATCH 7/9] tools build: Allow subprojects select all feature checkers Wang Nan
2016-01-13 12:17 ` [PATCH 8/9] perf build: Select all feature checkers for feature-dump Wang Nan
2016-01-14 10:18 ` Jiri Olsa
2016-01-13 12:17 ` [PATCH 9/9] perf build: Use feature dump file for build-test Wang Nan
2016-01-14 10:19 ` Jiri Olsa
2016-01-14 10:24 ` Wangnan (F)
2016-01-14 12:44 ` Jiri Olsa
2016-01-14 10:23 ` Jiri Olsa
2016-01-14 1:54 ` [PATCH 0/9] perf build: Make build-test faster Wangnan (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114100445.GD31454@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox